rebase with main

Author: couvq

x-pack/platform/plugins/shared/streams/server/lib/streams/client.ts

@@ -11,13 +11,14 @@ import type {
   IndicesDataStream,
   IndicesGetDataStreamResponse,
   QueryDslQueryContainer,
+  Result,
 } from '@elastic/elasticsearch/lib/api/types';
-import type { IScopedClusterClient, KibanaRequest, Logger } from '@kbn/core/server';
+import type { IScopedClusterClient, Logger, KibanaRequest } from '@kbn/core/server';
 import { isNotFoundError } from '@kbn/es-errors';
-import type { LockManagerService } from '@kbn/lock-manager';
-import type { Condition } from '@kbn/streamlang';
 import type { RoutingStatus } from '@kbn/streams-schema';
 import { Streams, getAncestors, getParentId } from '@kbn/streams-schema';
+import type { LockManagerService } from '@kbn/lock-manager';
+import type { Condition } from '@kbn/streamlang';
 import type { AssetClient } from './assets/asset_client';
 import type { QueryClient } from './assets/query/query_client';
 import {
@@ -26,11 +27,9 @@ import {
 } from './errors/definition_not_found_error';
 import { SecurityError } from './errors/security_error';
 import { StatusError } from './errors/status_error';
-import { StreamsStatusConflictError } from './errors/streams_status_conflict_error';
-import type { FeatureClient } from './feature/feature_client';
 import { LOGS_ROOT_STREAM_NAME, rootStreamDefinition } from './root_stream_definition';
-import { State } from './state_management/state';
 import type { StreamsStorageClient } from './storage/streams_storage_client';
+import { State } from './state_management/state';
 import { checkAccess, checkAccessBulk } from './stream_crud';
 import { StreamsStatusConflictError } from './errors/streams_status_conflict_error';
 import type { FeatureClient } from './feature/feature_client';
@@ -326,23 +325,6 @@ export class StreamsClient {
       throw new StatusError(`Child stream ${name} already exists`, 409);
     }
 
-    // TODO - These constants need to be shared between both plugins so I don't have to duplicate them
-    // TODO: need to know prefix to do min check properly
-    logger.info(`parent: ${parent}, \n name: ${name}`);
-    const MIN_NAME_LENGTH = 6; // 'logs.' is already included which is 5 characters, so user must enter at least one more.
-    const MAX_NAME_LENGTH = 200;
-
-    if (name.length < MIN_NAME_LENGTH) {
-      throw new StatusError('Stream name must not be empty.', 400);
-    }
-
-    if (name.length > MAX_STREAM_NAME_LENGTH) {
-      throw new StatusError(
-        `Stream name cannot be longer than ${MAX_STREAM_NAME_LENGTH} characters.`,
-        400
-      );
-    }
-
     await State.attemptChanges(
       [
         {

x-pack/platform/plugins/shared/streams_app/public/components/data_management/stream_detail_routing/stream_name_form_row.tsx

@@ -16,8 +16,8 @@ import {
 } from '@elastic/eui';
 import { css } from '@emotion/react';
 import { i18n } from '@kbn/i18n';
-import React from 'react';
 import { MAX_STREAM_NAME_LENGTH } from '@kbn/streams-plugin/public';
+import React from 'react';
 import { useStreamsRoutingSelector } from './state_management/stream_routing_state_machine';
 
 interface StreamNameFormRowProps {
@@ -69,21 +69,11 @@ export function StreamNameFormRow({
   const prefix = parentStreamName + '.';
   const partitionName = value.replace(prefix, '');
 
-  const isLengthValid = value.length > prefix.length && value.length <= MAX_NAME_LENGTH;
+  const isStreamNameEmpty = value.length <= prefix.length;
+  const isStreamNameTooLong = value.length > MAX_STREAM_NAME_LENGTH;
+  const isLengthValid = !isStreamNameEmpty && !isStreamNameTooLong;
 
-  const helpText =
-    value.length >= MAX_NAME_LENGTH && !readOnly
-      ? i18n.translate('xpack.streams.streamDetailRouting.maximumNameHelpText', {
-          defaultMessage: `Stream name cannot be longer than {maxLength} characters.`,
-          values: {
-            maxLength: MAX_NAME_LENGTH,
-          },
-        })
-      : value.length <= prefix.length && !readOnly
-      ? i18n.translate('xpack.streams.streamDetailRouting.minimumNameHelpText', {
-          defaultMessage: `Stream name is required.`,
-        })
-      : undefined;
+  const helpText = getHelpText(isStreamNameEmpty, isStreamNameTooLong, readOnly);
 
   const isDotPresent = !readOnly && partitionName.includes('.');
   const dotErrorMessage = isDotPresent