Merge branch 'main' into data-registry-apm-types

Author: sorenlouv

oas_docs/output/kibana.yaml

@@ -77107,6 +77107,9 @@ paths:
           required: true
           schema:
             type: string
+      responses:
+        '200':
+          description: OK
       summary: Delete a monitor
       tags:
         - synthetics
@@ -77278,6 +77281,9 @@ paths:
                 - $ref: '#/components/schemas/Synthetics_tcpMonitorFields'
               type: object
         required: true
+      responses:
+        '200':
+          description: OK
       summary: Update a monitor
       tags:
         - synthetics
@@ -77448,11 +77454,11 @@ paths:
         - content: Kibana
           name: product_name
   /api/synthetics/params/_bulk_delete:
-    delete:
+    post:
       description: |
         **Spaces method and path for this operation:**
 
-        <div><span class="operation-verb delete">delete</span>&nbsp;<span class="operation-path">/s/{space_id}/api/synthetics/params/_bulk_delete</span></div>
+        <div><span class="operation-verb post">post</span>&nbsp;<span class="operation-path">/s/{space_id}/api/synthetics/params/_bulk_delete</span></div>
 
         Refer to [Spaces](https://www.elastic.co/docs/deploy-manage/manage-spaces) for more information.
 
@@ -77529,6 +77535,9 @@ paths:
           required: true
           schema:
             type: string
+      responses:
+        '200':
+          description: OK
       summary: Delete a parameter
       tags:
         - synthetics
@@ -77830,6 +77839,9 @@ paths:
             maxLength: 1024
             minLength: 1
             type: string
+      responses:
+        '200':
+          description: OK
       summary: Delete a private location
       tags:
         - synthetics
@@ -103915,6 +103927,8 @@ components:
               type: string
             synthetics_args:
               description: Synthetics agent CLI arguments.
+              items:
+                type: string
               type: array
             type:
               description: The monitor type.
@@ -104073,7 +104087,7 @@ components:
     Synthetics_httpMonitorFields:
       allOf:
         - $ref: '#/components/schemas/Synthetics_commonMonitorFields'
-        - additionalproperties: true
+        - additionalProperties: true
           type: object
           properties:
             check:

src/platform/packages/private/kbn-validate-oas/src/oas_error_baseline.json

@@ -1,4 +1,4 @@
 {
-  "./oas_docs/output/kibana.yaml": 1249,
+  "./oas_docs/output/kibana.yaml": 1244,
   "./oas_docs/output/kibana.serverless.yaml": 1137
 }

x-pack/solutions/observability/plugins/synthetics/docs/openapi/synthetic_apis.yaml

@@ -281,6 +281,9 @@ paths:
           required: true
           schema:
             type: string
+      responses:
+        "200":
+          description: OK
     get:
       summary: Get a monitor
       operationId: get-synthetic-monitor
@@ -442,6 +445,9 @@ paths:
                     "inline_script": "step('Go to https://google.com.co', () => page.goto('https://www.google.com'))",
                     "locations": ["united_kingdom"]
                   }
+      responses:
+       "200":
+          description: OK
   /api/synthetics/monitors/_bulk_delete:
     post:
       summary: Delete monitors
@@ -671,6 +677,9 @@ paths:
           required: true
           schema:
             type: string
+      responses:
+        "200":
+          description: OK
     get:
       summary: Get a parameter
       operationId: get-parameter
@@ -783,7 +792,7 @@ paths:
                       "tags": ["authentication", "security", "updated"]
                     }
   /api/synthetics/params/_bulk_delete:
-    delete:
+    post:
       summary: Delete parameters
       operationId: delete-parameters
       description: >
@@ -990,6 +999,9 @@ paths:
             type: string
             minLength: 1
             maxLength: 1024
+      responses:
+        "200":
+          description: OK
     get:
       summary: Get a private location
       operationId: get-private-location
@@ -1297,6 +1309,8 @@ components:
             synthetics_args:
               type: array
               description: Synthetics agent CLI arguments.
+              items:
+                type: string
             type:
               type: string
               description: The monitor type.
@@ -1310,7 +1324,7 @@ components:
           required:
             - type
             - url
-          additionalproperties: true
+          additionalProperties: true
           properties:
             check:
               type: object

x-pack/solutions/security/packages/data-table/common/types/data_table/index.ts

@@ -26,6 +26,7 @@ export enum TableId {
   hostsPageSessions = 'hosts-page-sessions-v2', // the v2 is to cache bust localstorage settings as default columns were reworked.
   alertsOnRuleDetailsPage = 'alerts-rules-details-page',
   alertsOnAlertsPage = 'alerts-page',
+  alertsOnAttacksPage = 'attacks-page',
   alertsOnAlertSummaryPage = 'alert-summary-page',
   test = 'table-test', // Reserved for testing purposes
   alternateTest = 'alternateTest',
@@ -45,6 +46,7 @@ export enum TableEntityType {
 
 export const tableEntity: Record<TableId, TableEntityType> = {
   [TableId.alertsOnAlertsPage]: TableEntityType.alert,
+  [TableId.alertsOnAttacksPage]: TableEntityType.alert,
   [TableId.alertsOnAlertSummaryPage]: TableEntityType.alert,
   [TableId.alertsOnCasePage]: TableEntityType.alert,
   [TableId.alertsOnRuleDetailsPage]: TableEntityType.alert,
@@ -67,6 +69,7 @@ const TableIdLiteralRt = runtimeTypes.union([
   runtimeTypes.literal(TableId.hostsPageSessions),
   runtimeTypes.literal(TableId.alertsOnRuleDetailsPage),
   runtimeTypes.literal(TableId.alertsOnAlertsPage),
+  runtimeTypes.literal(TableId.alertsOnAttacksPage),
   runtimeTypes.literal(TableId.alertsOnAlertSummaryPage),
   runtimeTypes.literal(TableId.test),
   runtimeTypes.literal(TableId.rulePreview),

x-pack/solutions/security/plugins/security_solution/common/constants.ts

@@ -524,6 +524,7 @@ export const VIEW_SELECTION = {
 
 export const ALERTS_TABLE_REGISTRY_CONFIG_IDS = {
   ALERTS_PAGE: `${APP_ID}-alerts-page`,
+  ATTACKS_PAGE: `${APP_ID}-attacks-page`,
   RULE_DETAILS: `${APP_ID}-rule-details`,
   CASE: `${APP_ID}-case`,
   RISK_INPUTS: `${APP_ID}-risk-inputs`,

x-pack/solutions/security/plugins/security_solution/public/app/actions/toggle_column/cell_action/toggle_column.test.ts

@@ -114,6 +114,7 @@ describe('createToggleColumnCellActionFactory', () => {
       TableId.alertsOnCasePage,
       TableId.alertsOnRuleDetailsPage,
       TableId.alertsRiskInputs,
+      TableId.alertsOnAttacksPage,
     ].forEach((scopeId) => {
       it(`should call toggleColumn on the visible alerts table to add a column in alert for TableId ${scopeId}`, async () => {
         const name = 'fake-field-name';
@@ -136,6 +137,7 @@ describe('createToggleColumnCellActionFactory', () => {
       TableId.alertsOnCasePage,
       TableId.alertsOnRuleDetailsPage,
       TableId.alertsRiskInputs,
+      TableId.alertsOnAttacksPage,
     ].forEach((scopeId) => {
       it(`should call toggleColumn on the visible alerts table to remove a column in alert for TableId ${scopeId}`, async () => {
         await toggleColumnAction.execute({

x-pack/solutions/security/plugins/security_solution/public/common/components/cell_actions/cell_actions_renderer.test.tsx

@@ -123,6 +123,7 @@ describe('cell actions renderer', () => {
       TableId.alternateTest,
       TimelineId.casePage,
       TableId.alertsOnAlertsPage,
+      TableId.alertsOnAttacksPage,
       TableId.alertsOnRuleDetailsPage,
       TableId.hostsPageEvents,
       TableId.hostsPageSessions,

x-pack/solutions/security/plugins/security_solution/public/common/components/cell_actions/utils.test.tsx

@@ -21,6 +21,7 @@ const scopeIdsWithHoverActions = [
   TableId.alternateTest,
   TimelineId.casePage,
   TableId.alertsOnAlertsPage,
+  TableId.alertsOnAttacksPage,
   TableId.alertsOnRuleDetailsPage,
   TableId.hostsPageEvents,
   TableId.hostsPageSessions,

x-pack/solutions/security/plugins/security_solution/public/common/components/drag_and_drop/helpers.ts

@@ -11,7 +11,7 @@ import type { ActionCreator } from 'typescript-fsa';
 import type { FieldSpec } from '@kbn/data-plugin/common';
 
 import { getFieldIdFromDraggable, getProviderIdFromDraggable } from '@kbn/securitysolution-t-grid';
-import { TableId } from '@kbn/securitysolution-data-table';
+import { DETECTIONS_TABLE_IDS } from '../../../detections/constants';
 import { DEFAULT_COLUMN_MIN_WIDTH } from '../../../timelines/components/timeline/body/constants';
 import { getScopedActions } from '../../../helpers';
 import type { ColumnHeaderOptions } from '../../../../common/types';
@@ -221,10 +221,9 @@ export const addFieldToColumns = ({
   const fieldId = getFieldIdFromDraggable(result);
   const allColumns = getAllFieldsByName(browserFields);
   const column = allColumns[fieldId];
-  const initColumnHeader =
-    scopeId === TableId.alertsOnAlertsPage || scopeId === TableId.alertsOnRuleDetailsPage
-      ? defaultsHeader.find((c) => c.id === fieldId) ?? {}
-      : {};
+  const initColumnHeader = DETECTIONS_TABLE_IDS.some((tableId) => tableId === scopeId)
+    ? defaultsHeader.find((c) => c.id === fieldId) ?? {}
+    : {};
 
   const scopedActions = getScopedActions(scopeId);
   if (column != null && scopedActions) {

x-pack/solutions/security/plugins/security_solution/public/common/components/events_viewer/use_timelines_events.tsx

@@ -28,7 +28,8 @@ import type {
   TimelineRequestSortField,
   TimelineStrategyResponseType,
 } from '@kbn/timelines-plugin/common/search_strategy';
-import { dataTableActions, Direction, TableId } from '@kbn/securitysolution-data-table';
+import { dataTableActions, Direction } from '@kbn/securitysolution-data-table';
+import { DETECTIONS_TABLE_IDS } from '../../../detections/constants';
 import type { RunTimeMappings } from '../../../sourcerer/store/model';
 import { TimelineEventsQueries } from '../../../../common/search_strategy';
 import type { KueryFilterQueryKind } from '../../../../common/types';
@@ -39,8 +40,6 @@ import { useFetchNotes } from '../../../notes/hooks/use_fetch_notes';
 
 export type InspectResponse = Inspect & { response: string[] };
 
-export const detectionsTimelineIds = [TableId.alertsOnAlertsPage, TableId.alertsOnRuleDetailsPage];
-
 export type Refetch = () => void;
 
 export interface TimelineArgs {
@@ -168,7 +167,7 @@ export const useTimelineEventsHandler = ({
   const prevTimelineRequest = useRef<TimelineRequest | null>(null);
 
   const clearSignalsState = useCallback(() => {
-    if (id != null && detectionsTimelineIds.some((timelineId) => timelineId === id)) {
+    if (id != null && DETECTIONS_TABLE_IDS.some((timelineId) => timelineId === id)) {
       dispatch(dataTableActions.clearEventsLoading({ id }));
       dispatch(dataTableActions.clearEventsDeleted({ id }));
     }