fakerequest handling

Author: ppisljar

x-pack/platform/plugins/shared/onechat/server/services/agents/persisted/client/client.ts

@@ -18,6 +18,7 @@ import {
   type ToolSelection,
   type UserIdAndName,
 } from '@kbn/onechat-common';
+import { getUserFromRequest } from '../../../utils';
 import type {
   AgentCreateRequest,
   AgentDeleteRequest,
@@ -56,14 +57,9 @@ export const createClient = async ({
   toolsService: ToolsServiceStart;
   logger: Logger;
 }): Promise<AgentClient> => {
-  const authUser = security.authc.getCurrentUser(request);
-  if (!authUser) {
-    throw new Error('No user bound to the provided request');
-  }
-
+  const user = getUserFromRequest(request, security);
   const esClient = elasticsearch.client.asScoped(request).asInternalUser;
   const storage = createStorage({ logger, esClient });
-  const user = { id: authUser.profile_uid!, username: authUser.username };
 
   return new AgentClientImpl({ storage, user, request, space, toolsService });
 };

x-pack/platform/plugins/shared/onechat/server/services/conversation/conversation_service.ts

@@ -15,6 +15,7 @@ import type { SpacesPluginStart } from '@kbn/spaces-plugin/server';
 import { getCurrentSpaceId } from '../../utils/spaces';
 import type { ConversationClient } from './client';
 import { createClient } from './client';
+import { getUserFromRequest } from '@kbn/onechat-plugin/server/services/utils';
 
 export interface ConversationService {
   getScopedClient(options: { request: KibanaRequest }): Promise<ConversationClient>;
@@ -41,13 +42,8 @@ export class ConversationServiceImpl implements ConversationService {
   }
 
   async getScopedClient({ request }: { request: KibanaRequest }): Promise<ConversationClient> {
-    const authUser = this.security.authc.getCurrentUser(request);
-    if (!authUser) {
-      throw new Error('No user bound to the provided request');
-    }
-
+    const user = getUserFromRequest(request, this.security);
     const esClient = this.elasticsearch.client.asScoped(request).asInternalUser;
-    const user = { id: authUser.profile_uid!, username: authUser.username };
     const space = getCurrentSpaceId({ request, spaces: this.spaces });
 
     return createClient({ user, esClient, logger: this.logger, space });

x-pack/platform/plugins/shared/onechat/server/services/utils.ts

@@ -0,0 +1,17 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import type { KibanaRequest } from '@kbn/core-http-server';
+import type { SecurityServiceStart } from '@kbn/core-security-server';
+
+export const getUserFromRequest = (request: KibanaRequest, security: SecurityServiceStart) => {
+  const authUser = security.authc.getCurrentUser(request);
+  const user = authUser
+    ? { id: authUser.profile_uid!, username: authUser.username }
+    : { id: 'anonymous', username: 'anonymous' };
+  return user;
+};