Skip to content

Unskip gaps tests #225001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jul 15, 2025
Merged

Unskip gaps tests #225001

merged 26 commits into from
Jul 15, 2025

Conversation

nkhristinin
Copy link
Contributor

@nkhristinin nkhristinin commented Jun 24, 2025

Main Issue: #224475

Gaps update logic sometimes exited early. I removed that check, as updateGaps is only called from the cleanup function.

I also attempted to fix some other flaky gaps tests that occasionally caused duplicate alerts. This includes some gap removals and refreshes for gap creation.

related issue for possible source of flakines: #226437

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8431

[❌] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 25/50 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8433

[✅] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 25/25 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8434

[❌] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 24/50 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8444

[❌] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 0/100 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8447

[❌] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 0/100 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8449

[✅] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 50/50 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8451

[❌] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 175/200 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8536

[❌] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 0/200 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8540

[❌] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 58/100 tests passed.

see run history

@nkhristinin nkhristinin self-assigned this Jul 7, 2025
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8542

[❌] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 62/100 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8543

[❌] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 22/25 tests passed.

see run history

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8544

[❌] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 22/50 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8546

[❌] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 19/25 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8551

[✅] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 50/50 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8552

[✅] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 200/200 tests passed.

see run history

@nkhristinin nkhristinin added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels 8.19 candidate labels Jul 9, 2025
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -16,13 +16,24 @@ import { getEventLog } from '../../../../../common/lib/get_event_log';
export default function updateGapsTests({ getService }: FtrProviderContext) {
const supertest = getService('supertest');
const retry = getService('retry');
const logger = getService('log');

// Failing: See https://github.com/elastic/kibana/issues/224475
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can remove the comment too

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8571

[❌] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 175/200 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8582

[❌] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 0/200 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8611

[❌] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 174/200 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8626

[❌] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 175/200 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8633

[❌] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 0/200 tests passed.

see run history

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8636

[❌] x-pack/platform/test/alerting_api_integration/security_and_spaces/group1/config.ts: 171/200 tests passed.

see run history

@nkhristinin
Copy link
Contributor Author

Original issue was fixed. We have some flaky tests. Looks like it related to this issue of event log duplication of documents.

#226437

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin nkhristinin enabled auto-merge (squash) July 15, 2025 06:40
@nkhristinin nkhristinin merged commit 39c721c into elastic:main Jul 15, 2025
11 of 12 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @nkhristinin

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 16, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225001 locally
cc: @nkhristinin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.19 candidate backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants