Skip to content

Remove playwright-chromium package from dependencies #225221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Remove playwright-chromium package from dependencies #225221

merged 1 commit into from
Jun 25, 2025
+35 −6

Conversation

mykolaharmash
Copy link
Contributor

@mykolaharmash mykolaharmash commented Jun 25, 2025 •
edited
Loading

This change remove playwright-chromium package from Kibana dependencies.

  • The package isn't used anywhere in the codebase
  • The package conflicts with @playwright/test by installing the same playwright executable which then misses a bunch of features, including the test command

@mykolaharmash mykolaharmash added ci:scout-ui-tests Run Scout UI tests release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jun 25, 2025
@mykolaharmash mykolaharmash force-pushed the remove-playwright-chromium branch from b243d36 to 4dd2e9d Compare June 25, 2025 08:47
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@dmlemeshko dmlemeshko requested review from Copilot and dmlemeshko June 25, 2025 11:33
Copilot
Copilot AI reviewed Jun 25, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR removes the unused playwright-chromium dependency to eliminate conflicts with @playwright/test and streamline the codebase.

  • Deleted the playwright-chromium entry from dependencies in package.json
Comments suppressed due to low confidence (1)

package.json:1905

  • Please regenerate the lockfile (e.g., package-lock.json or yarn.lock) after removing this dependency to avoid orphaned entries and ensure reproducible installs.
    "playwright": "1.53.1",

dmlemeshko
dmlemeshko approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @mykolaharmash 👏

@mykolaharmash mykolaharmash added backport:skip This commit does not require backporting backport:version Backport to applied version labels v9.0.4 and removed backport:skip This commit does not require backporting labels Jun 25, 2025
@mykolaharmash mykolaharmash merged commit 4250dfb into elastic:main Jun 25, 2025
20 checks passed
mykolaharmash added a commit to mykolaharmash/kibana that referenced this pull request Jun 25, 2025
@mykolaharmash
Remove playwright-chromium package from dependencies (elastic#225221)
156f47a 
This change remove `playwright-chromium` package from Kibana
dependencies.
* The package isn't used anywhere in the codebase
* The package conflicts with `@playwright/test` by installing the same
`playwright` executable which then misses a bunch of features, including
the `test` command

(cherry picked from commit 4250dfb)

# Conflicts:
#	package.json
#	yarn.lock
@mykolaharmash mykolaharmash mentioned this pull request Jun 25, 2025
Open
@mykolaharmash
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

This was referenced Jun 26, 2025
Merged
Merged
Merged
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 27, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

3 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine kibanamachine mentioned this pull request Jul 3, 2025
Merged
1 task
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine kibanamachine mentioned this pull request Jul 6, 2025
Merged
1 task
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

7 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@dmlemeshko dmlemeshko dmlemeshko approved these changes

Assignees
No one assigned
Labels
backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels ci:scout-ui-tests Run Scout UI tests release_note:skip Skip the PR/issue when compiling release notes v9.0.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mykolaharmash @elasticmachine @kibanamachine @dmlemeshko