[Rules] Fix error message for missing data view in custom threshold #227727
+114
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileycash-elastic
added
the
bug
baileycash-elastic
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
github-actions
bot
added
the
author:obs-ux-management
baileycash-elastic
changed the title
davismcphee
reviewed
Jul 14, 2025
src/platform/plugins/shared/data_views/public/content_management_wrapper.ts
Outdated
Show resolved
Hide resolved
baileycash-elastic
requested review from
davismcphee
and removed request for
a team
...lugins/observability/public/components/custom_threshold/custom_threshold_rule_expression.tsx
Outdated
Show resolved
Hide resolved
davismcphee
reviewed
Jul 14, 2025
...lugins/observability/public/components/custom_threshold/custom_threshold_rule_expression.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@baileycash-elastic Will this fix also resolve this issue: #135641?
There was a problem hiding this comment.
The implementations of the rule form & data view component are similar, but not exactly the same. They both initiate a search source and default data view, so my solution could be worked in.
💚 Build Succeeded
Metrics [docs]Async chunks
|
kdelemme
approved these changes
Jul 16, 2025
|
Starting backport for target branches: 8.18, 8.19, 9.0, 9.1 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 16, 2025
…lastic#227727) ## Summary Resolves elastic#220855 https://github.com/user-attachments/assets/9e6fb2a5-7319-41c5-9609-873ce6c96b52 (cherry picked from commit 57f976d)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 16, 2025
…lastic#227727) ## Summary Resolves elastic#220855 https://github.com/user-attachments/assets/9e6fb2a5-7319-41c5-9609-873ce6c96b52 (cherry picked from commit 57f976d)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 16, 2025
…lastic#227727) ## Summary Resolves elastic#220855 https://github.com/user-attachments/assets/9e6fb2a5-7319-41c5-9609-873ce6c96b52 (cherry picked from commit 57f976d)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 16, 2025
…lastic#227727) ## Summary Resolves elastic#220855 https://github.com/user-attachments/assets/9e6fb2a5-7319-41c5-9609-873ce6c96b52 (cherry picked from commit 57f976d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 16, 2025
…hold (#227727) (#228320) # Backport This will backport the following commits from `main` to `9.0`: - [[Rules] Fix error message for missing data view in custom threshold (#227727)](#227727) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bailey Cash","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-07-16T20:42:35Z","message":"[Rules] Fix error message for missing data view in custom threshold (#227727)\n\n## Summary\n\nResolves #220855 \n\n\nhttps://github.com/user-attachments/assets/9e6fb2a5-7319-41c5-9609-873ce6c96b52","sha":"57f976d62f7b7ce798626d511745688001575b05","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:SharedUX","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.2.0","v8.18.4","v9.0.4"],"title":"[Rules] Fix error message for missing data view in custom threshold","number":227727,"url":"https://github.com/elastic/kibana/pull/227727","mergeCommit":{"message":"[Rules] Fix error message for missing data view in custom threshold (#227727)\n\n## Summary\n\nResolves #220855 \n\n\nhttps://github.com/user-attachments/assets/9e6fb2a5-7319-41c5-9609-873ce6c96b52","sha":"57f976d62f7b7ce798626d511745688001575b05"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","8.18","9.0"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227727","number":227727,"mergeCommit":{"message":"[Rules] Fix error message for missing data view in custom threshold (#227727)\n\n## Summary\n\nResolves #220855 \n\n\nhttps://github.com/user-attachments/assets/9e6fb2a5-7319-41c5-9609-873ce6c96b52","sha":"57f976d62f7b7ce798626d511745688001575b05"}},{"branch":"8.18","label":"v8.18.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Bailey Cash <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 16, 2025
…hold (#227727) (#228322) # Backport This will backport the following commits from `main` to `9.1`: - [[Rules] Fix error message for missing data view in custom threshold (#227727)](#227727) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bailey Cash","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-07-16T20:42:35Z","message":"[Rules] Fix error message for missing data view in custom threshold (#227727)\n\n## Summary\n\nResolves #220855 \n\n\nhttps://github.com/user-attachments/assets/9e6fb2a5-7319-41c5-9609-873ce6c96b52","sha":"57f976d62f7b7ce798626d511745688001575b05","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:SharedUX","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.2.0","v8.18.4","v9.0.4"],"title":"[Rules] Fix error message for missing data view in custom threshold","number":227727,"url":"https://github.com/elastic/kibana/pull/227727","mergeCommit":{"message":"[Rules] Fix error message for missing data view in custom threshold (#227727)\n\n## Summary\n\nResolves #220855 \n\n\nhttps://github.com/user-attachments/assets/9e6fb2a5-7319-41c5-9609-873ce6c96b52","sha":"57f976d62f7b7ce798626d511745688001575b05"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","8.18","9.0"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227727","number":227727,"mergeCommit":{"message":"[Rules] Fix error message for missing data view in custom threshold (#227727)\n\n## Summary\n\nResolves #220855 \n\n\nhttps://github.com/user-attachments/assets/9e6fb2a5-7319-41c5-9609-873ce6c96b52","sha":"57f976d62f7b7ce798626d511745688001575b05"}},{"branch":"8.18","label":"v8.18.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Bailey Cash <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 16, 2025
…shold (#227727) (#228318) # Backport This will backport the following commits from `main` to `8.18`: - [[Rules] Fix error message for missing data view in custom threshold (#227727)](#227727) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bailey Cash","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-07-16T20:42:35Z","message":"[Rules] Fix error message for missing data view in custom threshold (#227727)\n\n## Summary\n\nResolves #220855 \n\n\nhttps://github.com/user-attachments/assets/9e6fb2a5-7319-41c5-9609-873ce6c96b52","sha":"57f976d62f7b7ce798626d511745688001575b05","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:SharedUX","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.2.0","v8.18.4","v9.0.4"],"title":"[Rules] Fix error message for missing data view in custom threshold","number":227727,"url":"https://github.com/elastic/kibana/pull/227727","mergeCommit":{"message":"[Rules] Fix error message for missing data view in custom threshold (#227727)\n\n## Summary\n\nResolves #220855 \n\n\nhttps://github.com/user-attachments/assets/9e6fb2a5-7319-41c5-9609-873ce6c96b52","sha":"57f976d62f7b7ce798626d511745688001575b05"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","8.18","9.0"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227727","number":227727,"mergeCommit":{"message":"[Rules] Fix error message for missing data view in custom threshold (#227727)\n\n## Summary\n\nResolves #220855 \n\n\nhttps://github.com/user-attachments/assets/9e6fb2a5-7319-41c5-9609-873ce6c96b52","sha":"57f976d62f7b7ce798626d511745688001575b05"}},{"branch":"8.18","label":"v8.18.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Bailey Cash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #220855
Screen.Recording.2025-07-13.at.11.36.56.PM.mov