Skip to content

chore(NA): upgrade typescript into v5.4.5 #227746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 38 commits into
base: main
Choose a base branch
from

Conversation

mistic
Copy link
Member

@mistic mistic commented Jul 12, 2025

Closes https://github.com/elastic/kibana-operations/issues/299

This PR bumps the Typescript version used on Kibana into v5.4.5. The full set of changes can be found here.

In order to make assumptions over the codebase and all the type of errors I choose to mark the failures with @ts-expect-error and let each team decide how to handle it.

There is a list below with the files (and teams those belong to) where the annotations were added. If each team could provide help of fixing the ones under their domain it would be fantastic. It can be done in this PR or in subsequent ones.

Here it goes the list for follow up:

@elastic/obs-ai-assistant

@elastic/stack-monitoring

@elastic/kibana-cases

@elastic/ml-ui

@elastic/obs-ux-logs-team

@elastic/obs-ux-infra_services-team

@elastic/obs-ux-management-team

@elastic/security-solution

Other changes are just a result from the need of upgrading the typescript eslint plugin version.

@mistic mistic added chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 v9.2.0 v9.0.4 labels Jul 12, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 12, 2025

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

@mistic mistic force-pushed the upgrade-typescript-5.4.5 branch 2 times, most recently from b4dd168 to 8f1ac41 Compare July 14, 2025 03:09
@mistic mistic force-pushed the upgrade-typescript-5.4.5 branch from fb15c8e to 88dc0fd Compare July 14, 2025 04:52
@elastic elastic deleted a comment from elasticmachine Jul 16, 2025
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
cases 19 17 -2
osquery 2 1 -1
securitySolution 98 97 -1
total -4

ESLint disabled line counts

id before after diff
@kbn/core-usage-data-server 1 0 -1
@kbn/docs-utils 8 9 +1
@kbn/interpreter 5 4 -1
canvas 33 35 +2
enterpriseSearch 2 16 +14
fleet 44 45 +1
lists 19 32 +13
ml 572 574 +2
osquery 116 95 -21
securitySolution 641 639 -2
total +8

Total ESLint disabled count

id before after diff
@kbn/core-usage-data-server 1 0 -1
@kbn/docs-utils 10 11 +1
@kbn/interpreter 5 4 -1
canvas 36 38 +2
cases 88 86 -2
enterpriseSearch 3 17 +14
fleet 56 57 +1
lists 24 37 +13
ml 575 577 +2
osquery 118 96 -22
securitySolution 739 736 -3
total +4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.19.0 v9.0.4 v9.1.0 v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants