-
Notifications
You must be signed in to change notification settings - Fork 8.4k
chore(NA): upgrade typescript into v5.4.5 #227746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mistic
wants to merge
38
commits into
elastic:main
Choose a base branch
from
mistic:upgrade-typescript-5.4.5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+676
−595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
b4dd168
to
8f1ac41
Compare
fb15c8e
to
88dc0fd
Compare
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
chore
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v8.19.0
v9.0.4
v9.1.0
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/kibana-operations/issues/299
This PR bumps the Typescript version used on Kibana into v5.4.5. The full set of changes can be found here.
In order to make assumptions over the codebase and all the type of errors I choose to mark the failures with
@ts-expect-error
and let each team decide how to handle it.There is a list below with the files (and teams those belong to) where the annotations were added. If each team could provide help of fixing the ones under their domain it would be fantastic. It can be done in this PR or in subsequent ones.
Here it goes the list for follow up:
@elastic/obs-ai-assistant
@elastic/stack-monitoring
@elastic/kibana-cases
@elastic/ml-ui
@elastic/obs-ux-logs-team
@elastic/obs-ux-infra_services-team
@elastic/obs-ux-management-team
@elastic/security-solution
Other changes are just a result from the need of upgrading the typescript eslint plugin version.