[agent builder] renaming #234883
Merged
[agent builder] renaming #234883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/ci |
pgayvallet
added
release_note:skip
jedrazb
reviewed
Sep 12, 2025
Member
jedrazb
left a comment
jedrazb
left a comment
There was a problem hiding this comment.
LGTM, You missed renaming apis in our readme
| export const ONECHAT_TITLE = 'Chat'; | ||
| export const ONECHAT_APP_ID = 'agent_builder'; | ||
| export const ONECHAT_PATH = '/app/agent_builder'; | ||
| export const ONECHAT_TITLE = 'Agent Builder'; |
Member
There was a problem hiding this comment.
i18n? this will be used for rendering labels in some parts of UI
Contributor
Author
There was a problem hiding this comment.
Yeah, now is the right time to do it 👍
jedrazb
approved these changes
Sep 12, 2025
| { | ||
| link: { navId: 'agent_builder' }, | ||
| breadcrumbs: ['Conversations'], | ||
| link: { deepLinkId: 'agent_builder' }, |
Contributor
There was a problem hiding this comment.
this needs to be navId so it can click the parent item. which isn't a deep link.
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
KodeRad
pushed a commit
to KodeRad/kibana
that referenced
this pull request
Sep 15, 2025
## Summary Part of elastic/search-team#10961 (sibling of elastic#234304) --------- Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
## Summary Part of elastic/search-team#10961 (sibling of elastic#234304) --------- Co-authored-by: kibanamachine <[email protected]>
niros1
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Summary Part of elastic/search-team#10961 (sibling of #234304) --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of https://github.com/elastic/search-team/issues/10961
(sibling of #234304)