From 1c6d09e6f166902436e62a700f85b21a6f2c9730 Mon Sep 17 00:00:00 2001 From: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com> Date: Thu, 31 Jul 2025 15:29:45 +0200 Subject: [PATCH 1/4] [ML] Removes unused translation (#230055) This caused a failure on main, likely due to a PR being merged around the same time as https://github.com/elastic/kibana/pull/229868, which removes the usage of the translation. From fa032c4a0163ee656a3b684cd8e3bebd4e3ebdca Mon Sep 17 00:00:00 2001 From: "paulina.shakirova" Date: Wed, 10 Sep 2025 11:29:26 +0200 Subject: [PATCH 2/4] [SideNav] Add custom tooltip offset as per design --- .../navigation/src/components/side_nav/primary_menu_item.tsx | 2 ++ src/core/packages/chrome/navigation/src/constants.ts | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/core/packages/chrome/navigation/src/components/side_nav/primary_menu_item.tsx b/src/core/packages/chrome/navigation/src/components/side_nav/primary_menu_item.tsx index 0f98437779813..f6e03af198d24 100644 --- a/src/core/packages/chrome/navigation/src/components/side_nav/primary_menu_item.tsx +++ b/src/core/packages/chrome/navigation/src/components/side_nav/primary_menu_item.tsx @@ -18,6 +18,7 @@ import type { MenuItem } from '../../../types'; import { MenuItem as MenuItemComponent } from '../menu_item'; import { useTooltip } from '../../hooks/use_tooltip'; import { BetaBadge } from '../beta_badge'; +import { TOOLTIP_OFFSET } from '../../constants'; export interface SideNavPrimaryMenuItemProps extends MenuItem { as?: 'a' | 'button'; @@ -116,6 +117,7 @@ export const SideNavPrimaryMenuItem = forwardRef {menuItem} diff --git a/src/core/packages/chrome/navigation/src/constants.ts b/src/core/packages/chrome/navigation/src/constants.ts index e421ef22e923c..380ee281113a6 100644 --- a/src/core/packages/chrome/navigation/src/constants.ts +++ b/src/core/packages/chrome/navigation/src/constants.ts @@ -18,4 +18,4 @@ export const POPOVER_HOVER_DELAY = 100; export const TOP_BAR_HEIGHT = 48; export const TOP_BAR_POPOVER_GAP = 8; export const BOTTOM_POPOVER_GAP = 17; -export const POPOVER_OFFSET = 5; +export const TOOLTIP_OFFSET = -8; From 93e6a851605b166662706e7dc9df0c0bbab8c0ef Mon Sep 17 00:00:00 2001 From: "paulina.shakirova" Date: Mon, 15 Sep 2025 12:31:33 +0200 Subject: [PATCH 3/4] unify tooltip for all cases --- .../chrome/navigation/src/components/side_nav/footer_item.tsx | 2 ++ src/core/packages/chrome/navigation/src/constants.ts | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/core/packages/chrome/navigation/src/components/side_nav/footer_item.tsx b/src/core/packages/chrome/navigation/src/components/side_nav/footer_item.tsx index 316e396f873b5..66a5a68aedea9 100644 --- a/src/core/packages/chrome/navigation/src/components/side_nav/footer_item.tsx +++ b/src/core/packages/chrome/navigation/src/components/side_nav/footer_item.tsx @@ -16,6 +16,7 @@ import { EuiButtonIcon, EuiToolTip, useEuiTheme } from '@elastic/eui'; import type { MenuItem } from '../../../types'; import { useTooltip } from '../../hooks/use_tooltip'; import { BetaBadge } from '../beta_badge'; +import { TOOLTIP_OFFSET } from '../../constants'; export interface SideNavFooterItemProps extends Omit, MenuItem { hasContent?: boolean; @@ -81,6 +82,7 @@ export const SideNavFooterItem = forwardRef {menuItem} diff --git a/src/core/packages/chrome/navigation/src/constants.ts b/src/core/packages/chrome/navigation/src/constants.ts index 380ee281113a6..fb1f5ed6a2ef4 100644 --- a/src/core/packages/chrome/navigation/src/constants.ts +++ b/src/core/packages/chrome/navigation/src/constants.ts @@ -18,4 +18,4 @@ export const POPOVER_HOVER_DELAY = 100; export const TOP_BAR_HEIGHT = 48; export const TOP_BAR_POPOVER_GAP = 8; export const BOTTOM_POPOVER_GAP = 17; -export const TOOLTIP_OFFSET = -8; +export const TOOLTIP_OFFSET = 4; From 0ff77f42930586d12012c85e2a1dbc24ba6d48cb Mon Sep 17 00:00:00 2001 From: "paulina.shakirova" Date: Mon, 15 Sep 2025 14:33:00 +0200 Subject: [PATCH 4/4] fix mistake of renaming --- src/core/packages/chrome/navigation/src/constants.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/core/packages/chrome/navigation/src/constants.ts b/src/core/packages/chrome/navigation/src/constants.ts index fb1f5ed6a2ef4..f5d0a25ca967d 100644 --- a/src/core/packages/chrome/navigation/src/constants.ts +++ b/src/core/packages/chrome/navigation/src/constants.ts @@ -18,4 +18,5 @@ export const POPOVER_HOVER_DELAY = 100; export const TOP_BAR_HEIGHT = 48; export const TOP_BAR_POPOVER_GAP = 8; export const BOTTOM_POPOVER_GAP = 17; +export const POPOVER_OFFSET = 5; export const TOOLTIP_OFFSET = 4;