Unit test is failing when upgrading to logstash v9.0.1

[Sunanda533]

Hi,

We are upgrading to logstash v9.0.1 and there is issue observed in unit-test in pipeline.
But locally, there are no issues observed during build or unit-test.
Only in pipeline, unit-test is being failed.
And the errors are mostly related to Logstash::Runner

Below is the example of error.

`LogStash::Runner pipeline settings config.debug should allow overriding config.debug

Failure/Error:

expect(LogStash::Agent).to receive(:new) do |settings|

expect(settings.get("config.debug")).to eq(true)

end

(LogStash::Agent (class)).new(*(any args))

expected: 1 time with any arguments

received: 0 times with any arguments

./logstash-core/spec/logstash/runner_spec.rb:335:in `block in

'

./vendor/bundle/jruby/3.1.0/gems/webmock-3.25.1/lib/webmock/rspec.rb:39:in `block in

'

./spec/spec_helper.rb:84:in `block in

'

./logstash-core/lib/logstash/util.rb:43:in `set_thread_name'

./spec/spec_helper.rb:83:in `block in

'

./spec/spec_helper.rb:76:in `block in

'

./vendor/bundle/jruby/3.1.0/gems/logstash-devutils-2.6.2-java/lib/logstash/devutils/rspec/spec_helper.rb:47:in `block in

'

./lib/bootstrap/rspec.rb:36:in <main>'
Similarly, 22 test failures are observed.

Can you please let us know your suggestions.

Thanks & regards,
Sunanda N.

[robbavey]

@Sunanda533 Can you explain how you are running the tests, and what other tests are failing?

[Sunanda533]

Hi @robbavey,

Actually we are running the tests like below.
./gradlew javaTests --stacktrace
./gradlew rubyTests --stacktrace

Attaching the document regarding test failures.

Unit-test_failures.txt

Thanks & regards,
Sunanda N.

[robbavey]

Looking at some of those errors, are you trying to run these tests as root?

[Sunanda533]

Hi,
One thing to be noticed here is, we tried to upgrade to logstash v8.18.0 and there are no issues observed.
And with v9.0.1 the issue is observed, the main difference between these two versions is modules framework is removed in latest logstash version.
We suspect removal of modules framework cause this issue.
Please let us know your suggestions.
Thanks & regards,
Sunanda N.

[kaisecheng]

@Sunanda533 I wasn't able to reproduce the issue using the following steps:

git checkout v9.0.1
./gradlew rubyTests --stacktrace

[Sunanda533]

Hi @kaisecheng,

As mentioned earlier, we tried to upgrade to logstash v8.18.0 and there are no issues observed.
And with v9.0.1 the issue is observed, the main difference between these two versions is modules framework is removed in latest logstash version.
We suspect removal of modules framework cause this issue.
Locally I do not see any unit-test failure, issue is observed only in pipeline.
Can you please let me know if you have run the tests in local or in pipeline.
Also please let us know your suggestions how to proceed further or how we can adapt the modules framework.

Thanks & regards,
Sunanda N.

[robbavey]

@Sunanda533

Looking at some of those errors, are you trying to run these tests as root?

I ask this question again, because running as root is denied by default in 9.x, and some of the unit tests were showing failures that looked like they were being run as root.

[Sunanda533]

Hi @robbavey,

Yeah, seems tests are run as root by default.
May be I will try to change to non-root and run the tests to check the behavior.

Thanks & regards,
Sunanda N.

[Sunanda533]

Hi @robbavey,

Can you please let me know how to run as non-root user.

Thanks & regards,
Sunanda N.

[Sunanda533]

Hi @robbavey,

I tried to run the tests by enabling 'allow_superuser' and now there are 3 failures observed.
Attaching the failure scenarios.

3failures_rubyTests.txt

Can you please let us know your suggestions if we can enable 'allow_superuser' to avoid unit-test failures or there is any other alternative to proceed further.

Thanks & regards,
Sunanda N.

[robbavey]

@Sunanda533 Running tests as root is not supported, and is something you should fix in your local environment.

Ensure that your test runner is not running as root, or under sudo. If you are running in CI, make sure that your CI user is not running as root

[Sunanda533]

Hi @robbavey,

Can you please let us know if there are any docker flags for USER/USER_ID to run logstash as non-root user.

Thanks & regards,
Sunanda N.