-
Notifications
You must be signed in to change notification settings - Fork 37
[connector/elasticapm] Add ability configure metric aggregation limit configs #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[connector/elasticapm] Add ability configure metric aggregation limit configs #626
Conversation
…anaged-server default values
max_cardinality: 8000 | ||
overflow: | ||
attributes: | ||
- key: "overflow" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I was thinking we could probably not expose these attributes for this component, so a user just defines the max cardinality for each limit. Or at least define some defaults such as:
overflow:
attributes:
- key: "overflow"
value: true
- key: "component"
value: "connector/elasticapmconnector"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added default overflow attribute values
Exposed aggregation limit configs that are propagated to the
lsmintervalprocessor
.Note: I opted to keep the configuration names (
resource_limit
) the same as thelsmintervalprocessor
mostly so they are consistent for both components. Another option would be to restructure everything to omit the_limit
suffix soelasticapm::aggregation::limit::resource
andelasticapm::aggregation::limit::scope
. Let me know what you think.Checklist
connector/elasticapmconnector/README.md
to includes the limits in the example config.ymlapm-managed-service/checkout/apm-aggregation-service/config/config.go
Local Testing
make genelasticcol
local_test_1
,local_test_2
)telemetrygen traces --duration 1s --otlp-insecure --service "local_test_1"
Search for overflow metric documents with query
labels.overflow:true
to validate overflow behaviorExample Overflow metric
Reference
Closes : #465