PHP: escape dollar variables

Author: miguelgrinberg

src/exporters/php.ts

@@ -70,7 +70,10 @@ export class PHPExporter implements FormatExporter {
     } else if (data === null || data === undefined) {
       return (startIndented ? indent : "") + "null";
     } else if (typeof data === "string") {
-      return (startIndented ? indent : "") + JSON.stringify(data);
+      return (
+        (startIndented ? indent : "") +
+        JSON.stringify(data).replaceAll("${", "\\${")
+      );
     } else if (Array.isArray(data)) {
       const elements =
         data.length === 0

tests/convert.test.ts

@@ -394,6 +394,24 @@ $resp1 = $client->search([
     ],
 ]);
 
+`,
+    );
+  });
+
+  it("converts a dollar-variable to php", async () => {
+    expect(
+      await convertRequests('POST /my-index/_doc\n{"key":"${value}"}', "php", {
+        complete: false,
+        elasticsearchUrl: "https://localhost:9999",
+      }),
+    ).toEqual(
+      `$resp = $client->index([
+    "index" => "my-index",
+    "body" => [
+        "key" => "\\\${value}",
+    ],
+]);
+
 `,
     );
   });