populate admin_features_package and product_types in ec_security_project ReadI() #939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_project Read()
The Read() function in ec_security_project was not populating the
admin_features_package and product_types fields from the API response,
causing them to remain in an 'unknown' state after resource creation.
This resulted in Terraform errors: 'Provider returned invalid result
object after apply'.
This fix adds the missing field population logic in the Read() function:
- admin_features_package uses NewStringPointerValue() pattern (matching
observability_project pattern for optional pointer fields)
- product_types is converted from API response format to Terraform list
Updated tests to verify the fields are correctly populated.
Fixes elastic#938
Assisted by Cursor AI.
norrietaylor
force-pushed
the
fix/security-project-read-unknown-fields
branch
2 times, most recently
from
37300d1 to
9644ee7
Compare
… doesn't return them
norrietaylor
force-pushed
the
fix/security-project-read-unknown-fields
branch
from
9644ee7 to
a957266
Compare
tobio
reviewed
Nov 21, 2025
| resource ec_security_project "%s" { | ||
| name = "%s" | ||
| region_id = "%s" | ||
| admin_features_package = "standard" |
Member
There was a problem hiding this comment.
We need to have at least one acceptance test which verifies that these values can be set, and updated successfully by the provider.
| type securityModelReader struct{} | ||
|
|
||
| // productTypesOrderInsensitivePlanModifier ignores order differences in product_types list | ||
| type productTypesOrderInsensitivePlanModifier struct{} |
Member
There was a problem hiding this comment.
Based on the comment here, I think we actually want to create a custom type for the product types. That type can then implement ListValuableWithSemanticEquals which:
- Applies the same logic as this plan modifier during the planning phase
- Critically, applies the same logic during the post application checks which will avoid the inconsistent state error I imagine we'd get if the TF config defined product types in a different order to what was returned by the API.
| productTypeValues := []attr.Value{} | ||
|
|
||
| if len(sourceProductTypes) > 0 { | ||
| // Use the ordering from state/config, but with values from API |
Member
There was a problem hiding this comment.
See the custom type comment above. We can bundle all this logic i.e the plan modifier and this ordering shenanigans into the custom type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Read() function in ec_security_project was not populating the
admin_features_package and product_types fields from the API response,
causing them to remain in an 'unknown' state after resource creation.
This resulted in Terraform errors: 'Provider returned invalid result
object after apply'.
This fix adds the missing field population logic in the Read() function:
Updated tests to verify the fields are correctly populated.
Fixes #938
Assisted by Cursor AI.