fix: Enable getNode to follow directory links (fixes #248) (#318)

* Add test failing to stat symlinked file

This demonstrates issue #248

* (fix #248) follow directory links in getNode

When called from stat, getNode should follow directory links to
ensure that the correct node is returned. Otherwise, node.files[name]
will be undefined, causing a TypeError.

Author: AndreasFranek

src/filesystem.ts

@@ -190,9 +190,12 @@ export class Filesystem {
     return files;
   }
 
-  getNode(p: string) {
+  getNode(p: string, followLinks: boolean = true): FilesystemEntry {
     const node = this.searchNodeFromDirectory(path.dirname(p));
     const name = path.basename(p);
+    if ('link' in node && followLinks) {
+      return this.getNode(path.join(node.link, name));
+    }
     if (name) {
       return (node as FilesystemDirectoryEntry).files[name];
     } else {
@@ -201,7 +204,7 @@ export class Filesystem {
   }
 
   getFile(p: string, followLinks: boolean = true): FilesystemEntry {
-    const info = this.getNode(p);
+    const info = this.getNode(p, followLinks);
 
     if (!info) {
       throw new Error(`"${p}" was not found in this archive`);

test/api-spec.js

@@ -168,4 +168,8 @@ describe('api', function () {
 
     assert.deepStrictEqual(topLevelFunctions, defaultExportFunctions);
   });
+  it('should stat a symlinked file', async () => {
+    const stats = asar.statFile('test/input/stat-symlink.asar', 'real.txt', true);
+    return assert.strictEqual(stats.link, undefined);
+  });
 });