Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 🚋 emoji is actually a tram. #7138

Closed
Half-Shot opened this issue Aug 3, 2018 · 9 comments
Closed

The 🚋 emoji is actually a tram. #7138

Half-Shot opened this issue Aug 3, 2018 · 9 comments
Labels
S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect

Comments

@Half-Shot
Copy link
Member

Half-Shot commented Aug 3, 2018

This caused a lot of disruption when I said I was taking a 🚋 to the office.

EDIT: The proof is here https://emojipedia.org/tram-car/

Steps to reproduce

  • Type :train: into the composer.

An emoji of a tram (🚋) shows up next to the text :train:.

Version information

  • Platform: web (in-browser)

For the web app:

  • URL: riot.im/develop
@michaelkaye
Copy link
Contributor

...

@lampholder
Copy link
Member

I'm tempted to make a P6 label just for this bug 😄

More seriously, I don't know where we get our :word: -> emoji mapping, but Github (as the first example to hand) also thinks that 🚋 is a :train:. As does Android.

@lampholder lampholder added p5 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users labels Aug 13, 2018
@aaronraimist
Copy link
Collaborator

Pretty sure it comes from the shortnames in here: https://github.com/emojione/emojione/blob/v2.2.7/emoji.json
(https://github.com/matrix-org/matrix-react-sdk/pull/2085/files#diff-9c6d157ed970be15913b7569c44ad765)

"tram": {
    "unicode": "1f68a",
    "unicode_alt": "",
    "code_decimal": "🚊",
    "name": "tram",
    "shortname": ":tram:",
    "category": "travel",
    "emoji_order": "1610",
    "aliases": [],
    "aliases_ascii": [],
    "keywords": [
      "transportation",
      "travel",
      "train"
    ]
  },
  "train": {
    "unicode": "1f68b",
    "unicode_alt": "",
    "code_decimal": "🚋",
    "name": "tram car",
    "shortname": ":train:",
    "category": "travel",
    "emoji_order": "1613",
    "aliases": [],
    "aliases_ascii": [],
    "keywords": [
      "transportation",
      "travel",
      "train"
    ]
  },

@kiliankoe
Copy link

kiliankoe commented Feb 24, 2019

And :hamburger: stills shows a cheeseburger 🙈

This is obviously a serious issue, see this.

"One might argue that the compound effect of this blunder could result in tens of dollars of losses across Slack's userbase," Huber wrote.

Please upgrade to p1, thanks 👌

@Half-Shot
Copy link
Member Author

I still think about this issue 🤔

@turt2live
Copy link
Member

We're taking out emojione (#9281), so this will shortly become a problem for your operating system vendor.

@Half-Shot
Copy link
Member Author

Half-Shot commented Mar 26, 2019

We're taking out emojione (#9281), so this will shortly become a problem for your operating system vendor.

Hold up, the problem was because the mapping of :train: became 🚊. Does removing emojiOne actually fix the mapping issue. Also 99% certain my OS won't be mapping.

@turt2live
Copy link
Member

Removing emojione does help in that we get to more easily define our own mappings, so I think it would eventually. I'd prefer to keep this closed though until emojione is removed and in front of users though: an issue this small is not really worth the anxiety caused by looking at the issue list, and it is likely more suited as a 30 second PR.

@aaronraimist
Copy link
Collaborator

Just adding a note here that emojibase does seem to correctly call 🚆 a :train:

matrix-org/matrix-react-sdk#2995
https://github.com/milesj/emojibase/blob/master/packages/generator/src/resources/shortcodes.ts#L925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

6 participants