Skip to content

protobuf_generate and FileDescriptor #39

@mjheilmann

Description

@mjheilmann

We have code to compensate for the service definitions of protobuf_generate being a FileDescriptorProto instead of a ServiceDescriptorProto. But we handle it by simply extracting the ServiceDescriptorProto and passing that into the original builder code.

When we are presented with a FileDescriptorProto, we should use it directly as a reflection payload instead of ignoring the FileDescriptorProto and simulating our own. ref

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions