Lazy don't work like it should

[ghivert]

The lazy function doesn't work like it should. Today it adds a div between the function body and the parent container.

Let's take an example.

-- Counter.elm

module Counter exposing (..)

import BodyBuilder as B
import BodyBuilder.Attributes as A

myView : Int -> B.NodeWithStyle msg
myView counter = 
  B.div [ A.id "first-div" ]
    [ B.lazy myCounter counter ]
  
myCounter : Int -> B.NodeWithStyle msg
myCounter counter =
  B.div [ A.id "second-div" ]
    [ B.text counter ]

This results in:

<div id="first-div">
  <div style="height: 100%; overflow: scroll;"> <!-- This div should be stylizable on its own. -->
    <div id="second-div">
      counter
    </div>
  </div>
</div>

[tibastral]

agreed !

…

-- Thibaut

Le 29 janv. 2020 à 18:28, Guillaume Hivert ***@***.***> a écrit :  The lazy function don't work like it should. Today it adds a div between the function body and the parent container. Let's take an example. -- Counter.elm module Counter exposing (..) import BodyBuilder as B import BodyBuilder.Attributes as A myView : Int -> B.NodeWithStyle msg myView counter = B.div [ A.id "first-div" ] [ B.lazy myCounter counter ] myCounter : Int -> B.NodeWithStyle msg myCounter counter = B.div [ A.id "second-div" ] [ B.text counter ] This results in: <div id="first-div"> <div style="height: 100%; overflow: scroll;"> <!-- This div should be stylizable on its own. --> <div id="second-div"> counter </div> </div> </div> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[ghivert]

Shouldn't we be using inherit for every important property? Instead of anything else, just get the properties from parent and use them in the div to make the div transparent?

[tibastral]

no I hate inherit

…

-- Thibaut

Le 31 janv. 2020 à 15:41, Guillaume Hivert ***@***.***> a écrit :  Shouldn't we be using inherit for every important property? Instead of anything else, just get the properties from parent and use them in the div to make the div transparent? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.