You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@rlefevre opened up #109 recently, and I had to look into what maximumBy and minimumBy do. I felt like the documentation was a little confusing. Like the term 'first maximum' was unintuitive to me. I guess theres no reason you couldnt have multiple maximums (if the two maximum are equal and above all the others) but its not a part of the normal connotation.
Then also, there are no code examples for these functions. There should be.
Is it just me that finds the documentation on these lacking? I dont really want to go off and fix these things up if its just me.
The text was updated successfully, but these errors were encountered:
Oh I didnt even think about returning a list of maximums. Thats interesting. I just meant it could be phrased better. Like I would write "It returns the maximum, if there are two maximums it returns the first one" or something. In the first clause of the sentence it says what it does in the simplest and most intuitive way, in the second clause, the sentence covers this edge case thats not immediately obvious.
@rlefevre opened up #109 recently, and I had to look into what
maximumBy
andminimumBy
do. I felt like the documentation was a little confusing. Like the term 'first maximum' was unintuitive to me. I guess theres no reason you couldnt have multiple maximums (if the two maximum are equal and above all the others) but its not a part of the normal connotation.Then also, there are no code examples for these functions. There should be.
Is it just me that finds the documentation on these lacking? I dont really want to go off and fix these things up if its just me.
The text was updated successfully, but these errors were encountered: