Deleting instance not working when hideLastAddForm is true

[corneliusabel]

When using inline formsets (extra=1, can_delete=True) and hideLastAddForm=true the deletion of an instance (after submitting) fails. However, with hideLastAddForm=false deletion works.
I noticed that the only difference in the POST requests was the "TOTAL_FORMS" field which was n-1 when hideLastAddForm=true. That has prevented the deletion of the object in django.
By commenting out line "totalForms.val(forms.length);" in line 95 (1.5-pre) i could fix that for me.

However, iam not an javascript expert so not sure if this is the right solution?

Best,

Cornelius

[ridoo]

My observation is rather that TOTAL_FORMS counter is decremented on delete. See

django-dynamic-formset/src/jquery.formset.js

Lines 94 to 95 in 38475fb

	forms = $('.' + options.formCssClass).not(':hidden');
	totalForms.val(forms.length);

and

django-dynamic-formset/src/jquery.formset.js

Lines 98 to 100 in 38475fb

	// Update the TOTAL_FORMS count:
	forms = $('.' + options.formCssClass).not('.formset-custom-template');
	totalForms.val(forms.length);

For what I traced in the Django code is, that the TOTAL_FORMS count has to include both visible and hidden form groups in the formset, as all form data is POSTed (deleted ones are marked with DELETE: "on" attribute). Decreasing the counter would not make the formset creating any (initial) forms for data having an index bigger than the decreased TOTAL_FORMS .