This fixes the issue #136 for me #137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To recap the issue, if the formset starts hidden then the remove links don't appear. I'm not sure what this might break, but seems to work so far for me...
|
This was also an issue for me using Bootstrap tabs where I have a formset per tab. Current behavior isn't consistent with the add button since this appears on the hidden tab, but not the remove button. This change matches what I've had to do myself to get it to work. |
|
If the maintainer of this repo is still around, it would be great to get this merged. I'm not sure what the purpose of not doing this for invisible forms might've been? |
|
Would be great to see this merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To recap the issue, if the formset starts hidden then the remove links don't appear.
I'm not sure what this might break, but seems to work so far for me...