Minor cleanup

Author: eltoder

src/components/Chat.js

@@ -124,14 +124,16 @@ function Chat({
   const databasePath = gameId ? `chats/${gameId}` : "lobbyChat";
   const messagesQuery = useMemo(
     () =>
-      firebase
-        .database()
-        .ref(databasePath)
-        .orderByChild("time")
-        .limitToLast(messageLimit),
-    [databasePath, messageLimit]
+      isHidden
+        ? null
+        : firebase
+            .database()
+            .ref(databasePath)
+            .orderByChild("time")
+            .limitToLast(messageLimit),
+    [isHidden, databasePath, messageLimit]
   );
-  const messages = useFirebaseQuery(isHidden ? null : messagesQuery);
+  const messages = useFirebaseQuery(messagesQuery);
   const mentionRE = useMemo(() => makeMentionRE(user.name), [user.name]);
 
   function handleSubmit(event) {

src/components/ProfileGamesTable.js

@@ -64,7 +64,7 @@ function ProfileGamesTable({ userId, gamesData, handleClickGame }) {
   if (Object.keys(gamesData).length === 0) {
     return (
       <Typography style={{ color: grey[400] }}>
-        No recent games to display...
+        No recent games in this category.
       </Typography>
     );
   }

src/pages/LobbyPage.js

@@ -120,22 +120,21 @@ function LobbyPage() {
   const [gameMode] = useStorage("gameMode", "normal");
   const [practiceMode] = useStorage("practiceMode", "off");
 
-  const gamesQuery = useMemo(() => {
-    return firebase
-      .database()
-      .ref("publicGames")
-      .orderByValue()
-      .limitToLast(35);
-  }, []);
+  const gamesQuery = useMemo(
+    () => firebase.database().ref("publicGames").orderByValue().limitToLast(35),
+    []
+  );
   const games = useFirebaseQuery(gamesQuery);
 
-  const myGamesQuery = useMemo(() => {
-    return firebase
-      .database()
-      .ref(`/userGames/${user.id}`)
-      .orderByValue()
-      .limitToLast(35);
-  }, [user.id]);
+  const myGamesQuery = useMemo(
+    () =>
+      firebase
+        .database()
+        .ref(`/userGames/${user.id}`)
+        .orderByValue()
+        .limitToLast(35),
+    [user.id]
+  );
   const myGames = useFirebaseQuery(myGamesQuery);
 
   const [stats, loadingStats] = useFirebaseRef("stats");

src/pages/ProfilePage.js

@@ -81,7 +81,7 @@ function ProfilePage({ match }) {
       .database()
       .ref(`/userGames/${userId}`)
       .orderByValue()
-      .limitToLast(64);
+      .limitToLast(100);
     const update = (snapshot) => {
       query.off("value", update);
       setGames(snapshot.val() ?? {});
@@ -114,9 +114,6 @@ function ProfilePage({ match }) {
   if (redirect) {
     return <Redirect push to={redirect} />;
   }
-  if (!gameIds) {
-    return <LoadingPage />;
-  }
 
   let gamesData = null;
   if (!loadingGameVals && !loadingGameDataVals) {