Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline node properties not opening and blank screen is shown, Also in inputs -> Filename -> Browse is not showing files and folder. #3105

Open
r5shivam opened this issue Feb 9, 2023 · 4 comments
Labels
component:pipeline-editor pipeline editor kind:bug Something isn't working

Comments

@r5shivam
Copy link

r5shivam commented Feb 9, 2023

Describe the issue

  1. In Kubeflow pipeline with elyra when I try to open node proerties it shows blank screen first time, then if I close and reopen the pipeline file node properties opens successfully.
  2. In node properties if I try to Browse and select the component file it just shows empty panel with nothing to select.

To Reproduce
Steps to reproduce the 1st behavior:

  1. Go to 'Node Component'
  2. Click on 'Open properties'
  3. Close the 'Pipeline File'
  4. Open the 'Pipeline File'
  5. Now try to open node properties it will work.

Steps to reproduce the 2st behavior:

  1. Go to 'Node Properties'
  2. Click on 'Browse in Filename'
  3. Try to change the directory in the panel shown after 2nd step.
  4. You'll get empty panel with nothing to select.

Screenshots or log output
If applicable, add screenshots or log output to help explain your problem.

Screenshot 2023-02-09 at 2 30 58 PM

Screenshot 2023-02-09 at 2 31 36 PM

Screenshot 2023-02-09 at 2 32 03 PM

Expected behavior

  1. Node properties should open the first time.
  2. Browse for Filename should show all the files/directories.

Deployment information
Describe what you've deployed and how:

  • Elyra version: =~ 3.13.0, 3.14.2, 3.14.0, 3.14.1
  • Installation source: [official container image, custom container image]
  • Deployment type: [Kubeflow [notebook server]]
  • Operating system: [linux]
  • Kubeflow Version: 1.3.0
@r5shivam r5shivam changed the title Pipeline node properties not opening and black screen is shown, Also in inputs -> Filename -> Browse is not showing files and folder. Pipeline node properties not opening and blank screen is shown, Also in inputs -> Filename -> Browse is not showing files and folder. Feb 9, 2023
@ptitzler ptitzler added kind:bug Something isn't working component:pipeline-editor pipeline editor labels Feb 9, 2023
@ptitzler
Copy link
Member

ptitzler commented Feb 9, 2023

A quick comment about the last screen capture. In general the file picker will only display files of the pre-selected type. For example, the file picker for a Python component will only display files with the .py extension. The file picker should also display subdirectories, irrespective of whether they contain files of the selected type or not.

It appears that this might be a regression issue with how the the file picker handles subdirectories. I've confirmed the problem using the following directory layout in the Jupyterlab work directory:

afile.py
adir/anotherfile.py
adir/thirdfile.py

Note that this behavior is not file type specific (e.g. Python vs Jupyter notebook)

  • [Works as expected]
    • Create a new pipeline
    • In the file browser navigate to the adir subdirectory and drag a file onto the canvas to create a generic node
    • Open the node's properties: the file selection is properly reflected in the UI
    • Choose another file from the same subdirectory
  • [Does not work]
    • Create a new pipeline
    • In the file browser navigate to the Jupyterlab work directory and drag a file onto the canvas to create a generic node
    • Open the node's properties: the file selection is properly reflected in the UI
    • Open the file picker
    • [Issue] The subdirectory adir is not listed and no files can be selected from this directory location
  • [Does not work]
    • Create a new pipeline
    • Create a generic node using the Python file component
    • Open the node's properties
    • Open the file picker
    • [Issue] The subdirectory adir is not listed and no files can be selected from this directory location

@AlirezaSadeghi
Copy link

Hey guys, any updates on this? I was trying Elyra out for an MVP proposal, and this came up, and seems quite basic not to be working 😢

@lresende
Copy link
Member

@AlirezaSadeghi While I see the issues reported by @ptitzler overall I was able to get all other stuff working by using drag and drop or selecting files from the Jupyter Browser. Is this actually blocking you? Would you be willing to help with the fix?

@alejovicu
Copy link

Any updates on this? I'm facing the same issue. I know jupyterlab > 4 is not supported but are there any plans to start supporting it?

elyra==3.15.0
jupyterlab==4.0.9
notebook==7.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:pipeline-editor pipeline editor kind:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants