Skip to content

BSARDRetrieval does not cover multi-article queries #2906

@nikolay-banar

Description

@nikolay-banar

Describe the bug

BSARDRetrieval does not cover multi-article queries and uses the last document from the list of relevant documents.

To reproduce

I believe that this snippet of code from BSARDRetrieval contains a bug:

for q in queries_raw:
    for doc_id in q["article_ids"]:
        self.relevant_docs[self.metadata.eval_splits[0]][str(q["id"])] = {
            str(doc_id): 1
        }

It uses only the last document from q["article_ids"], but it does not seem to be intended.

Additional information

No response

Are you interested to contribute a fix for this bug?

Yes

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions