rename onExit to something else

[stefanpenner]

onExit to closely implies it has the exact behavior of process.on('exit but as it is async it does not. Especially when it comes to which exist status code is chosen during some race scenarios.

[rwjblue]

Thanks @stefanpenner, we can circle back to this when we have free cycles...

[stefanpenner]

Ya, the original intent was to be like on("exit" but this was before understanding the various exit code precedence rules. At which point it became obvious it needed to become a different thing.

[stefanpenner]

one idea:

var captureExit = require('capture-exit');
captureExit.captureExit();

captureExit.asyncCleanup(function() { // renamed from onExit
  return ensureCleanup();
});

process.on('exit', function() {
  process.exit(1);
});

[hjdivad]

@rwjblue @stefanpenner perhaps beforeExit is the better analog.

1. it allows async code, as beforeExit does
2. its process.exit(code) semantics are closer to beforeExit's

The difference is that beforeExit code in node is not guaranteed to be run. capture-exit more or less gives you a way of writing a beforeExit handler that will reliably run.

[stefanpenner]

I'm nervous it is not quite the as node existing beforeExit. I believe our hook fires in more cases then beforeExit If that isn't true maybe its fine, but otherwise a unique name may be appropriate.

[hjdivad]

@stefanpenner yes our hook absolutely does fire more often than node's does.

The difference is that beforeExit code in node is not guaranteed to be run. capture-exit more or less gives you a way of writing a beforeExit handler that will reliably run.

It was the point I was making ^.

Still I can see that this difference may be enough to not want to make an analogy to any of node's exit event hooks at all.

[stefanpenner]

we could called it betterBeforeExit or actuallyBeforeExit or something funny :P

[hjdivad]

beforeExitAndIMeanActuallyRunLikeAllTheTimeBecauseYouNeedThisShitToHappen

[stefanpenner]

beforeExitAndIMeanActuallyRunLikeAllTheTimeBecauseYouNeedThisShitToHappen

sounds like the one!

[ro0gr]

what about addHandler?

var captureExit = require('capture-exit');
captureExit.captureExit();

captureExit.addHandler(function() {
  return ensureCleanup();
});