Skip to content

Improvements to getPageTitle test-support helper #212

@raido

Description

@raido

We probably should add comment block so IDEs could give hints of expected parameters OR provide TypeScript interface file. I think proper JSDoc for starters would be nice.

This helper does have some internal logic comments in it, we should probably remove it or separate it still for testing specifically this addon vs public helper.

The Array.pop() workaround for consumers is not needed, it's only applicable for tests in this repository.

Originally posted by @raido in #209 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions