Issues with semi-colons?

[machty]

Historically we've disabled semi-colons in our eslint/prettier setup (but it's not really important for us to keep it that way), and I think I'm finding that ember-template-imports requires/assumes you're using semi colons due to the following:

export default class StarRating2Component extends GlimmerComponent<StarRatingSignature> {
  ratings = [1, 2, 3, 4, 5]

  <template>
    <div ...attributes>
      ...
    </div>
  </template>
}

yields error

[0]   20 |SyntaxError: /Users/machty/code/fpr/fpr-ember/packages/@futureproofretail/shopper-app/@futureproofretail/shopper-app/components/star-rating-2.ts: Attempted to use `<template>` to define a template in an unsupported way. Templates defined using this syntax must be:
[0] 
[0] 1. Assigned to a variable declaration OR
[0] 2. The default export of a file OR
[0] 2. In the top level of the file on their own (sugar for `export default`) OR
[0] 4. Used directly within a named class body
[0]   15 |
[0]   16 | export default class StarRating2Component extends GlimmerComponent<StarRatingSignature> {
[0] > 17 |   ratings = [1, 2, 3, 4, 5]
[0]      |             ^
[0]   18 |
[0]   19 |   
[0]   20 |
[0]     at File.buildCodeFrameError (/Users/machty/code/fpr/fpr-ember/node_modules/.pnpm/@babel+core@7.23.7/node_modules/@babel/core/lib/transformation/file/file.js:205:12)

If I add a semi-colon after ratings, it compiles.

I searched this repo for "semi-colon" and this is the only issue comment that turned up: #31

[NullVoxPopuli]

Which ember-template-imports version are you using?

[machty]

I'm on 3.4.2

[machty]

I'd try 4.0.0 to see if it fixes but seems like @glint/environment-ember-template-imports needs a release.

packages/@futureproofretail/shared
├─┬ @glint/environment-ember-template-imports 1.2.1
│ └── ✕ unmet peer ember-template-imports@^3.0.0: found 4.0.0
└─┬ ember-stargate 0.5.0
  └─┬ ember-resources 6.4.2
    └─┬ ember-async-data 1.0.3
      └── ✕ unmet peer ember-source@>=4.8.4: found 3.28.12

[machty]

Also I ended up just changing to semi-colons for my projects; wasn't too tied to non-semi-colons and it seemed to cause more friction with tooling and weird code formatting outputs sometimes.