Merge pull request #16 from Turbo87/element-id

Skip components that use `this.elementId`

Author: Turbo87

lib/__tests__/transform.js

@@ -149,6 +149,20 @@ test('throws if component is using `this.element`', () => {
   );
 });
 
+test('throws if component is using `this.elementId`', () => {
+  let source = `
+    export default Component.extend({
+      didInsertElement() {
+        console.log(this.elementId);
+      },
+    });
+  `;
+
+  expect(() => transform(source, '')).toThrowErrorMatchingInlineSnapshot(
+    `"Using \`this.elementId\` is not supported in tagless components"`
+  );
+});
+
 test('throws if component is using `keyDown()`', () => {
   let source = `
     export default Component.extend({

lib/transform.js

@@ -126,6 +126,15 @@ function transform(source, template, options = {}) {
     throw new SilentError(`Using \`this.element\` is not supported in tagless components`);
   }
 
+  // skip components that use `this.elementId`
+  let thisElementIdPaths = j(objectArg).find(j.MemberExpression, {
+    object: { type: 'ThisExpression' },
+    property: { name: 'elementId' },
+  });
+  if (thisElementIdPaths.length !== 0) {
+    throw new SilentError(`Using \`this.elementId\` is not supported in tagless components`);
+  }
+
   // skip components that use `click()` etc.
   for (let methodName of EVENT_HANDLER_METHODS) {
     let handlerMethod = properties.filter(path => isMethod(path, methodName))[0];