-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String input "all", followed by quickly changing query breaks search bar #842
Comments
To add to the original post, this doesn't seem to reproduce unless I fairly quickly type something else into the search bar which appears to result in a different console error:
|
What are you trying to search for when you type “all”? This may help with narrowing down the issue, if there’s some specific method in the docs that is the problem. |
Hey @jenweber, I think that I might have been looking for I stepped through the error a bit and I think that first one is happening because the entry associated with "node_modules/rsvp/lib/rsvp/promise/all.js" does not have a top level
This causes an error on line 16 in |
It looks like we get the same behavior any time that we search for We probably need to update the docs in some way so that these entries end up getting scoped to the right module rather than being undefined. Alternatively/Additionally, maybe we could update this DropdownResult component to drop those results which don't have the expected structure? Do you have any thoughts, @jenweber? |
When I enter the string "all" into the search bar on https://api.emberjs.com/ember/release, I see a console error logged:
After this error occurs, the search feature becomes unresponsive (so backing out "all" and then entering a new query string shows the old results).
The text was updated successfully, but these errors were encountered: