Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using "wide mode" in the redesign branch #879

Open
mansona opened this issue Aug 24, 2023 · 1 comment · Fixed by #881
Open

Start using "wide mode" in the redesign branch #879

mansona opened this issue Aug 24, 2023 · 1 comment · Fixed by #881

Comments

@mansona
Copy link
Member

mansona commented Aug 24, 2023 •
edited
Loading

We recently added "full width" mode to the sidebar implementation on the ember-styleguide, we should bring this implementation to the website-redesign branch 👍

https://ember-styleguide.netlify.app/components/sidebar
ember-learn/ember-styleguide#478
@mansona mansona converted this from a draft issue Aug 24, 2023
@mansona
Copy link
Member Author

mansona commented Aug 24, 2023

@lukasnys is going to take a look at this one too 👍

@mansona mansona moved this from Todo to In Progress in Redesign ember-api-docs Aug 24, 2023
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
chore(dependencies): upgrade ember-styleguide to latest (ember-learn#879
768fff6 
)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style: use full-width sidebar container (ember-learn#879)
91546e3
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style: add padding around sidebar and content (ember-learn#879)
79ef587
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style: match sidebar font-size with guidemaker-ember-template (ember-…
9482cea 
…learn#879)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style cleanup: move media queries down (ember-learn#879)
8ceef6d
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style: make header full-width (ember-learn#879)
84ab5f8
@lukasnys lukasnys mentioned this issue Sep 2, 2023
Merged
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style cleanup: only apply margin to content on desktop (ember-learn#879)
db5f26c
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style cleanup: only apply extra padding to header on desktop (ember-l…
6e0019d 
…earn#879)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style: match sidebar font-size with guidemaker-ember-template (ember-…
d7702ce 
…learn#879)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style cleanup: move media queries down (ember-learn#879)
1f4d1ec
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style: make header full-width (ember-learn#879)
c9cac7b
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style cleanup: only apply margin to content on desktop (ember-learn#879)
9277747
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style cleanup: only apply extra padding to header on desktop (ember-l…
ec3d802 
…earn#879)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style cleanup: move media queries down (ember-learn#879)
9c76475
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style: make header full-width (ember-learn#879)
1a97a2a
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style cleanup: only apply margin to content on desktop (ember-learn#879)
b2ecdd3
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style cleanup: only apply extra padding to header on desktop (ember-l…
885c694 
…earn#879)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style cleanup: move media queries down (ember-learn#879)
71784a9
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style: make header full-width (ember-learn#879)
837c067
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style cleanup: only apply margin to content on desktop (ember-learn#879)
bee54e8
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style cleanup: only apply extra padding to header on desktop (ember-l…
bf6e401 
…earn#879)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style: increase sidebar width to avoid items overflowing (ember-learn…
57be148 
…#879)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 2, 2023
style: increase sidebar width to avoid items overflowing (ember-learn…
7fc78bd 
…#879)
@MinThaMie MinThaMie moved this from In Progress to Done in Redesign ember-api-docs Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Redesign ember-api-docs
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API docs styling tweaks lukasnys/ember-api-docs
1 participant
@mansona