Skip to content

Error in embroider-esbuild-resolver with rolldown-vite@latest: Not implemented at Object.resolve #2513

@johanrd

Description

@johanrd

I am not sure about the intended status of supporting Rolldown at the moment, but I'm posting an issue here for visibility in case someone else gets tempted to try out rolldown-vite as a "drop-in replacement".

Steps to reproduce

  1. Clone this repo: https://github.com/johanrd/ember-vite (basically a fresh ember app + the vite codemod)
  2. run pnpm start and see that everything runs as expected
  3. Upgrade Vite to 7.0.0 in package json:
-    "vite": "^6.0.0"
+    "vite": "npm:rolldown-vite@latest"
  1. run pnpm start again, and see the following error:
9:11:12 PM [vite] (client) error while updating dependencies:
Error: Build failed with 17 errors:

[plugin embroider-esbuild-resolver]
Error: Not implemented
    at Object.resolve (file:///Users/j/ember-vite/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node_modules/rolldown-vite/dist/node/chunks/dep-MtNLhXu7.js:35038:11)
    at file:///Users/j/ember-vite/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]__@[email protected]._82ac92383dfdb8a5d1e4b19bd0d016dc/node_modules/@embroider/vite/dist/src/esbuild-resolver.js:94:50
    at PluginContextImpl.<anonymous> (file:///Users/j/ember-vite/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node_modules/rolldown-vite/dist/node/chunks/dep-MtNLhXu7.js:35115:24)
    at PluginContextImpl.resolveId (file:///Users/j/ember-vite/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node_modules/rolldown-vite/dist/node/chunks/dep-MtNLhXu7.js:35085:34)
    at async plugin (file:///Users/j/ember-vite/node_modules/.pnpm/[email protected]/node_modules/rolldown/dist/shared/src-Bob3e8Hh.mjs:2766:16)
    at async plugin.<computed> (file:///Users/j/ember-vite/node_modules/.pnpm/[email protected]/node_modules/rolldown/dist/shared/src-Bob3e8Hh.mjs:3657:12)

The error seems to come from vite/src/node/optimizer/pluginConverter.ts#L76-L78.

resolve() {
  throw new Error('Not implemented')
},

Context from @mansona on discord:

yea ideally we wouldn't need any of our strange esbuild hacks any more and can just use rollup apis to achieve what we need but like @NullVoxPopuli says, we're going to get "normal" vite working first 😂

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions