Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android persistence feature #4098

Closed
sbechet opened this issue Feb 25, 2024 · 3 comments · Fixed by #4423
Closed

android persistence feature #4098

sbechet opened this issue Feb 25, 2024 · 3 comments · Fixed by #4423

Comments

@sbechet
Copy link

sbechet commented Feb 25, 2024

Hello,

It seems eframe directories-next dependencies can't handle android.

Any idea how we can implement persistence on systems other than Linux, macOS, Redox and Windows?

Thank you.
@sbechet
Copy link
Author

sbechet commented Feb 26, 2024

logcat:

1708977138.478 10288  7286  7315 I eframe  : Both the glow and wgpu renderers are available. Using wgpu.
1708977138.481 10288  7286  7315 W winit::platform_impl:..: TODO: forward onStart notification to application
1708977138.502 10288  7286  7315 W eframe::native::file_..: Saving disabled: Failed to find path to data_dir.

How to get the path to the default shared folder in all androids around the world?

@sbechet
Copy link
Author

sbechet commented Feb 26, 2024

see dodometer as an example.

@YgorSouza
Copy link
Contributor

There is a discussion in the directories repo: dirs-dev/directories-rs#83.

@lucasmerlin lucasmerlin mentioned this issue Apr 27, 2024
Merged
emilk pushed a commit that referenced this issue May 27, 2024
@lucasmerlin
eframe: Add NativeOptions::persistence_path (#4423)
8553e73 
This allows customizing the persistence path in NativeOptions.
Previously, persistence wouldn't work with android because
directories-next doesn't support android so eframe would just fail to
find a place where it could store its config.

* Closes #4098 (android users can now specify a path that works with
android, by e.g. using app_dirs2, which supports android)
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@lucasmerlin @hacknus
eframe: Add NativeOptions::persistence_path (emilk#4423)
5f45cf9 
This allows customizing the persistence path in NativeOptions.
Previously, persistence wouldn't work with android because
directories-next doesn't support android so eframe would just fail to
find a place where it could store its config.

* Closes emilk#4098 (android users can now specify a path that works with
android, by e.g. using app_dirs2, which supports android)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

eframe: Add NativeOptions::persistence_path lucasmerlin/egui
2 participants
@sbechet @YgorSouza