Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control access to create/edit group functionality #46

Open
takkaria opened this issue Jul 26, 2018 · 7 comments
Open

Control access to create/edit group functionality #46

takkaria opened this issue Jul 26, 2018 · 7 comments

Comments

@takkaria
Copy link
Collaborator

takkaria commented Jul 26, 2018

Users we're creating for Nobel Grid have access to the groups UI and can create groups. It would be good to be able to disable this.

@takkaria takkaria changed the title Disallow users from creating/editing groups Control access to create/edit group functionality Jul 27, 2018
@takkaria
Copy link
Collaborator Author

Maybe Emon itself needs some kind of permissions system, so that you can grant users different capabilities?

@cagabi
Copy link
Collaborator

cagabi commented Jul 27, 2018

You are right that there is no control access in emonCMS. Basically you can be superadmin ("admin" column in users table) or normal user. This is because until we made the Group module the use for emnCMS has always been single users accessing their own data.
In terms of your point, I don't see the problem of users having access specifically to the Group module. It's a bit silly to have it there if they are not going to use it, but they also have access to all the other modules (input, feed, device) and we don't want the users to play with them. So I agree with you that a permissions system would be good.

@cagabi
Copy link
Collaborator

cagabi commented Jul 27, 2018

Thinking about it from a different angle: what is what we want for Nobel Grid users? Only access to the dashboards? Could there be a "Dashboard only" type of login?

@takkaria
Copy link
Collaborator Author

Yeah, I suppose I am also thinking that we need to disable access to a bunch of things for managed users. For user experience - so they don't have access to stuff that doesn't make sense for them / is useless - and also for privacy/data access reasons - if they change their device details for example they might be able to read other people's data. (Though I know Ben has written safeguards for this.)

@cagabi
Copy link
Collaborator

cagabi commented Jul 27, 2018

Oh interesting, you need to tell me how they can do that ;)
I guess the "only dashboard login" is a very specific solution while adding some kind of permissions system has a great potential

@takkaria
Copy link
Collaborator Author

I am going to spend some time this week trying to prototype a capability system. I'll let you know how I get on!

@takkaria takkaria reopened this Jul 31, 2018
@cagabi
Copy link
Collaborator

cagabi commented Aug 1, 2018

Cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants