SMA, EMA, MACD functions

[Noureddine-Reguieg]

Hello,

I wanted to provide some constructive feedback regarding the description of this repository. You claim that it includes functions for calculating EMA and SMA. However, after reviewing the code, I noticed that the EMA function requires previous_ema as an input. This undermines the purpose of providing an EMA calculation function because if I need to supply the previous EMA myself, the function's utility become meaningless!.

An actual EMA calculation function should handle all necessary computations, including the initialization of the first EMA value, perhaps using SMA or another method. Without this capability, the implementation feels incomplete and misleading for users who are looking for a fully functional EMA calculator.

I hope you can update the repository or its description to better reflect its current capabilities. Transparency is key to maintaining trust in open-source projects.

Best regards.

[emrementese]

Hi @Noureddine-Reguieg ,

• Firstly, thanks your constructive feedback. It's very important to me and I'm take into account.

• In this case, we were entegrating offical Binance API with binance-connector-python library.

Binance not give EMA information for cripto coins. If you want calculate to last EMA, you must use
previous EMA. You can't take a previous EMA with Binance. You must calculate. You need previous to previous EMA
to calculate previous EMA. This goes as far as the first EMA. If you want calculate to the first EMA, you must
use SMA in the EMA calculate. However, calculating first EMA using SMA is inconvenient and takes too long and
Binance has an api limit. Binance max give to the 1000 candlestick bars. You can't calculate SMA with this candlestick bars.

But,

We wrote this study 2-3 years ago by translating the original pine script codes into python with a stock market expert. It worked perfectly if the required values ​​were provided (initial conditions). It should be like that now. As you said, I wish there was a code that did not have to reference previous data, but then there was such an API.

Now,

Now that 2-3 years have passed, I will review the official Binance API documents again and if there is a change or there is a chance for another solution, I can refactor the project again. If you have an idea, please do not hesitate to express it. Open-source is strong together.

Best regards.

[emrementese]

Greetings, a small update: I switched the repo's dependency management to Poetry. Also, flake8 etc. to increase Code QA. I integrated the CI tool -pre-commit, which will ensure standards and automatically check this. On the CD side, I wrote a script with Github Actions that will update the pypi package when the stable release is released.

• Now I will focus on the main purpose of repo and see what can be done, stay tuned.