review

Author: arthur-encord

encord/objects/ontology_labels_impl.py

@@ -1264,59 +1264,25 @@ def __init__(self, images_data: LabelRowV2.LabelRowReadOnlyDataImagesDataEntry):
         @property
         def title(self) -> str:
             return self._image_data.title
-            """
-            Get the title of the image.
-
-            Returns:
-                str: The image title.
-            """
 
         @property
         def file_type(self) -> str:
             return self._image_data.file_type
-            """
-            Get the file type of the image.
-
-            Returns:
-                str: The image file type.
-            """
 
         @property
         def width(self) -> int:
             return self._image_data.width
-            """
-            Get the width of the image.
-
-            Returns:
-                int: The image width.
-            """
 
         @property
         def height(self) -> int:
             return self._image_data.height
-            """
-            Get the height of the image.
-
-            Returns:
-                int: The image height.
-            """
 
         @property
         def image_hash(self) -> str:
-            """Get the hash of the image.
-
-            Returns:
-                str: The image hash.
-            """
             return self._image_data.image_hash
 
         @property
         def frame_number(self) -> int:
-            """Get the frame number.
-
-            Returns:
-                int: The frame number.
-            """
             return self._image_data.index
 
     class FrameView:
@@ -1386,9 +1352,6 @@ def frame(self) -> int:
         def width(self) -> int:
             """Get the width of the frame.
 
-            Returns:
-                int: The width of the image or image group.
-
             Raises:
                 LabelRowError: If the width is not set for the data type.
             """
@@ -1400,8 +1363,7 @@ def width(self) -> int:
                     return frame_metadata.width
                 elif self._label_row_read_only_data.width is not None:
                     return self._label_row_read_only_data.width
-                else:
-                    raise LabelRowError(f"Width is expected but not set for the data type {self._label_row.data_type}")
+
             elif self._label_row_read_only_data.width is not None:
                 return self._label_row_read_only_data.width
             else:
@@ -1411,8 +1373,6 @@ def width(self) -> int:
         def height(self) -> int:
             """Get the height of the frame.
 
-            Returns:
-                int: The height of the image or image group.
 
             Raises:
                 LabelRowError: If the height is not set for the data type.
@@ -1425,8 +1385,7 @@ def height(self) -> int:
                     return frame_metadata.height
                 elif self._label_row_read_only_data.height is not None:
                     return self._label_row_read_only_data.height
-                else:
-                    raise LabelRowError(f"Height is expected but not set for the data type {self._label_row.data_type}")
+
             elif self._label_row_read_only_data.height is not None:
                 return self._label_row_read_only_data.height
             else:

tests/objects/test_bitmask_validation.py

@@ -185,8 +185,8 @@ def test_image_group_bitmask_dimension_validation():
     # Add bitmask with incorrect dimensions for frame 0 (256x256 instead of 512x512)
     frame_0_incorrect_mask = BitmaskCoordinates(np.zeros((256, 256), dtype=bool))
     frame_0_incorrect_instance = ObjectInstance(bitmask_object)
-    frame_0_incorrect_instance.set_for_frames(coordinates=frame_0_incorrect_mask, frames=0, overwrite=True)
-    label_row.add_object_instance(frame_0_incorrect_instance, force=True)
+    frame_0_incorrect_instance.set_for_frames(coordinates=frame_0_incorrect_mask, frames=0)
+    label_row.add_object_instance(frame_0_incorrect_instance)
 
     # Should fail on serialization
     with pytest.raises(ValueError, match="Bitmask dimensions don't match the media dimensions"):
@@ -198,8 +198,8 @@ def test_image_group_bitmask_dimension_validation():
 
     frame_1_incorrect_mask = BitmaskCoordinates(np.zeros((512, 512), dtype=bool))
     frame_1_incorrect_instance = ObjectInstance(bitmask_object)
-    frame_1_incorrect_instance.set_for_frames(coordinates=frame_1_incorrect_mask, frames=1, overwrite=True)
-    label_row.add_object_instance(frame_1_incorrect_instance, force=True)
+    frame_1_incorrect_instance.set_for_frames(coordinates=frame_1_incorrect_mask, frames=1)
+    label_row.add_object_instance(frame_1_incorrect_instance)
 
     # Should fail on serialization due to frame 1
     with pytest.raises(ValueError, match="Bitmask dimensions don't match the media dimensions"):
@@ -335,8 +335,8 @@ def test_dicom_bitmask_dimension_validation():
     # Add bitmask with incorrect dimensions for slice 0 (256x256 instead of 512x512)
     slice_0_incorrect_mask = BitmaskCoordinates(np.zeros((256, 256), dtype=bool))
     slice_0_incorrect_instance = ObjectInstance(bitmask_object)
-    slice_0_incorrect_instance.set_for_frames(coordinates=slice_0_incorrect_mask, frames=0, overwrite=True)
-    label_row.add_object_instance(slice_0_incorrect_instance, force=True)
+    slice_0_incorrect_instance.set_for_frames(coordinates=slice_0_incorrect_mask, frames=0)
+    label_row.add_object_instance(slice_0_incorrect_instance)
 
     # Should fail on serialization
     with pytest.raises(ValueError, match="Bitmask dimensions don't match the media dimensions"):