-
Notifications
You must be signed in to change notification settings - Fork 15
feat: ability to add client_metadata directly in folder.create_data_group - BOT-516 #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @arthur-encord, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily enhances the data group creation process by allowing users to attach arbitrary Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Unit test report (Python 3.9.24, Pydantic 2.12.3)269 tests 269 ✅ 9s ⏱️ Results for commit 3b1252e. ♻️ This comment has been updated with latest results. |
Unit test report (Python 3.9.24, Pydantic 1.10.22)269 tests 269 ✅ 8s ⏱️ Results for commit 3b1252e. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces two main changes: it adds the ability to include client_metadata when creating a data group, and it renames DataGroupList to DataGroupCarousel for clarity. The implementation is solid, with a nice enhancement to the @deprecated decorator to support class deprecation, ensuring backward compatibility for the renamed class. The addition of tests for the decorator is also a valuable improvement. Overall, the changes are well-executed and improve the SDK's functionality and clarity.
SDK integration test report285 tests ±0 275 ✅ - 2 14m 47s ⏱️ - 3m 25s For more details on these failures, see this check. Results for commit 3b1252e. ± Comparison against base commit dbabc87. ♻️ This comment has been updated with latest results. |
Introduction and Explanation
client_metadatatofolder.create_data_group