Optimise the RangeManager a bit since its now a lot more heavily used #1033

rad-cord · 2025-11-26T19:09:43Z

Introduction and Explanation

Replace the RangeManager implementation, with one backed by IntegerRangeSet which is a bit smarter about how it keeps tracks of ranges. Results in >100x speedup in situations where we deal with a lot of ranges

Tests

expand the coverage of functionality tests
added performance regression tests for the new RangeManager

Future work

The RangeManager is now a wrapper around an external class, and in python even the overhead of a function call is noticeable

gemini-code-assist · 2025-11-26T19:10:09Z

Summary of Changes

Hello @rad-cord, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a critical performance enhancement for range management within the system. It introduces a new, highly efficient IntegerRangeSet data structure and re-architects the RangeManager to leverage this new component. This results in substantial speed improvements for operations involving numerous ranges, addresses potential bottlenecks, and includes memory optimizations for Range objects. The changes are thoroughly validated with expanded unit and performance tests.

Highlights

Introduction of IntegerRangeSet: A new, highly optimized data structure for managing integer ranges is added, leveraging Python's bisect module for efficient operations like adding, removing, and finding intersections of ranges.
RangeManager Re-architecture: The existing RangeManager class is refactored to utilize the new IntegerRangeSet as its backend, leading to significant performance gains, especially for operations involving many ranges.
Performance Boost: The changes are expected to deliver a "greater than 100x speedup" in scenarios with heavy range usage, as stated in the PR description, by replacing less efficient list-based operations with bisect-optimized methods.
Memory Optimization for Range objects: The Range class now uses __slots__ to reduce memory footprint, which is beneficial for applications dealing with numerous range instances by preventing the creation of instance dictionaries.
Enhanced Test Coverage: Comprehensive unit tests have been added and updated for RangeManager, alongside a new dedicated suite of performance regression tests to ensure the optimizations are maintained and to prevent future performance degradations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2025-11-26T19:10:31Z

Unit test report (Python 3.9.24, Pydantic 1.10.22)

307 tests 307 ✅ 11s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit d410ebb.

♻️ This comment has been updated with latest results.

github-actions · 2025-11-26T19:10:34Z

Unit test report (Python 3.9.24, Pydantic 2.12.3)

307 tests 307 ✅ 11s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit d410ebb.

♻️ This comment has been updated with latest results.

gemini-code-assist

Code Review

This pull request introduces a significant performance optimization for RangeManager by replacing its list-based implementation with a new IntegerRangeSet class that uses bisect for more efficient range management. The changes are well-structured and include comprehensive unit and performance tests. My review focuses on further performance improvements, API design, and test clarity. Overall, this is a great improvement.

encord/common/range_manager.py

encord/common/integer_range_set.py

encord/common/range_manager.py

tests/utilities/test_range_manager_performance.py

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

github-actions · 2025-11-26T19:33:08Z

SDK integration test report

285 tests ±0 275 ✅ - 2 13m 0s ⏱️ - 5m 12s
1 suites ±0 4 💤 ±0
1 files ±0 6 ❌ +2

For more details on these failures, see this check.

Results for commit d410ebb. ± Comparison against base commit dbabc87.

♻️ This comment has been updated with latest results.

clinton-encord · 2025-11-27T10:33:28Z

tests/utilities/test_range_manager_performance.py

+"""Performance regression tests for RangeManager."""
+
+import time
+
+import pytest
+
+from encord.common.range_manager import RangeManager
+from encord.objects.frames import Range
+
+NUM_RANGES = 100_000
+
+# Performance thresholds (in seconds)
+# These are based on current performance and should alert if there's regression
+ADD_RANGES_THRESHOLD = 1
+ADD_RANGE_SEQUENTIAL_THRESHOLD = 1
+INIT_FRAMES_THRESHOLD = 1
+GET_RANGES_THRESHOLD = 1
+INTERSECTION_THRESHOLD = 1
+REMOVE_RANGE_THRESHOLD = 1


Crazy! Performance tests in the SDK? Love it.

clinton-encord · 2025-11-27T10:36:53Z

encord/common/integer_range_set.py

+        if start > end:
+            return


Wondering if an error should be thrown here instead.

Maybe the code that calls this should be the one that checks it I guess? But curious about your thoughts on this.

Good idea. There are some scenarios where you don't want to throw an error - where it's particularly expensive or the app "must not crash", but neither apply here

Optimise the RangeManager a bit since its now a lot more heavily used

557bd48

Relax timing thresholds

bdcbd80

gemini-code-assist bot reviewed Nov 26, 2025

View reviewed changes

rad-cord and others added 2 commits November 26, 2025 19:12

Relax timing thresholds

eb1a08d

Apply suggestions from code review

feefc4f

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

rad-cord requested review from anurag-encord and clinton-encord November 27, 2025 09:25

Ruff format

d410ebb

clinton-encord reviewed Nov 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Optimise the RangeManager a bit since its now a lot more heavily used #1033

Optimise the RangeManager a bit since its now a lot more heavily used #1033

rad-cord commented Nov 26, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Nov 26, 2025

Uh oh!

github-actions bot commented Nov 26, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 26, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 26, 2025 •

edited

Loading

Uh oh!

clinton-encord Nov 27, 2025

Uh oh!

clinton-encord Nov 27, 2025

Uh oh!

rad-cord Nov 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Optimise the RangeManager a bit since its now a lot more heavily used #1033

Are you sure you want to change the base?

Optimise the RangeManager a bit since its now a lot more heavily used #1033

Conversation

rad-cord commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Introduction and Explanation

Tests

Future work

Uh oh!

gemini-code-assist bot commented Nov 26, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit test report (Python 3.9.24, Pydantic 1.10.22)

Uh oh!

github-actions bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit test report (Python 3.9.24, Pydantic 2.12.3)

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK integration test report

Uh oh!

clinton-encord Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

clinton-encord Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

rad-cord Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rad-cord commented Nov 26, 2025 •

edited

Loading

github-actions bot commented Nov 26, 2025 •

edited

Loading

github-actions bot commented Nov 26, 2025 •

edited

Loading

github-actions bot commented Nov 26, 2025 •

edited

Loading