fixup! order of split params

Author: erights

packages/patterns/src/patterns/patternMatchers.js

@@ -1263,18 +1263,18 @@ const makePatternKit = () => {
    * @param {CopyArray} elements
    * @param {Pattern} elementPatt
    * @param {bigint} bound Must be >= 1n
-   * @param {Checker} check
    * @param {CopyArray} [inResults]
    * @param {CopyArray} [outResults]
+   * @param {Checker} [check]
    * @returns {boolean}
    */
   const elementsHasSplit = (
     elements,
     elementPatt,
     bound,
-    check,
     inResults = undefined,
     outResults = undefined,
+    check = identChecker,
   ) => {
     let count = 0n;
     for (const element of elements) {
@@ -1301,18 +1301,18 @@ const makePatternKit = () => {
    * @param {CopyArray<[Key, bigint]>} pairs
    * @param {Pattern} elementPatt
    * @param {bigint} bound Must be >= 1n
-   * @param {Checker} check
    * @param {CopyArray<[Key, bigint]>} [inResults]
    * @param {CopyArray<[Key, bigint]>} [outResults]
    * @returns {boolean}
+   * @param {Checker} [check]
    */
   const pairsHasSplit = (
     pairs,
     elementPatt,
     bound,
-    check,
     inResults = undefined,
     outResults = undefined,
+    check = identChecker,
   ) => {
     let count = 0n;
     for (const [element, num] of pairs) {
@@ -1368,13 +1368,34 @@ const makePatternKit = () => {
       }
       switch (kind) {
         case 'copyArray': {
-          return elementsHasSplit(specimen, elementPatt, bound, check);
+          return elementsHasSplit(
+            specimen,
+            elementPatt,
+            bound,
+            undefined,
+            undefined,
+            check,
+          );
         }
         case 'copySet': {
-          return elementsHasSplit(specimen.payload, elementPatt, bound, check);
+          return elementsHasSplit(
+            specimen.payload,
+            elementPatt,
+            bound,
+            undefined,
+            undefined,
+            check,
+          );
         }
         case 'copyBag': {
-          return pairsHasSplit(specimen.payload, elementPatt, bound, check);
+          return pairsHasSplit(
+            specimen.payload,
+            elementPatt,
+            bound,
+            undefined,
+            undefined,
+            check,
+          );
         }
         default: {
           return check(false, X`unexpected ${q(kind)}`);

packages/patterns/test/patterns.test.js

@@ -882,10 +882,12 @@ test('well formed patterns', t => {
   t.throws(() => M.has('c', 0n), {
     message: 'match:has payload: [1]: "[0n]" - Must be >= "[1n]"',
   });
+  // @ts-expect-error purposeful type violation for testing
   t.throws(() => M.has('c', M.nat()), {
     message:
       'match:has payload: [1]: A passable tagged "match:nat" is not a key: "[match:nat]"',
   });
+  // @ts-expect-error purposeful type violation for testing
   t.throws(() => M.has(3, 1), {
     message: 'match:has payload: [1]: 1 - Must be >= "[1n]"',
   });