Dependencies list non-existant package

[thekevinbrown]

Expected Behaviour
I expected to be able to install graphql-ws with npx but because npx automatically installs peer dependencies and there is no uWebSockets.js package on NPM, this happens instead: npm/cli#8196

Actual Behaviour
npm/cli#8196

Debug Information
npx graphweaver@latest init will reproduce this issue for you.

Right now we're recommending pnpx but it'd be great to get this package more broadly usable.

[enisdenjo]

Huh, that's weird. The dependency is listed as optional:

graphql-ws/package.json

Lines 147 to 149 in f54873c

	"uWebSockets.js": {
	"optional": true
	},

which is the npm official way of listing optional deps 😬.

[enisdenjo]

Could it have something to do with graphweaver itself? Because Hive Gateway also has a dependency on graphql-ws and npx @graphql-hive/gateway works without issues?

[thekevinbrown]

It's possible. I'm ultimately not fussed who is the source except to fix it. 👍

We depend on @graphql-codegen/cli, which does this:

graphweaver 2.17.4
  └─┬ @graphql-codegen/cli 5.0.6
    ├─┬ @graphql-tools/prisma-loader 8.0.17
    │ └─┬ @graphql-tools/url-loader 8.0.31
    │   └─┬ @graphql-tools/executor-graphql-ws 2.0.5
    │     └── graphql-ws 6.0.5
    ├─┬ @graphql-tools/url-loader 8.0.31
    │ └─┬ @graphql-tools/executor-graphql-ws 2.0.5
    │   └── graphql-ws 6.0.5
    └─┬ graphql-config 5.1.5
      └─┬ @graphql-tools/url-loader 8.0.31
        └─┬ @graphql-tools/executor-graphql-ws 2.0.5
          └── graphql-ws 6.0.5

@graphql-codegen/cli is of course made by the Hive team, so.... 🤷

Everything else is peer dependencies when I do pnpm why -r graphql-ws in a Graphweaver project. It seems odd that NPM would try to aggressively install an optional package and that this would behave differently when coming from @graphql-tools/executor-graphql-ws 2.0.5 which is exactly the same package as Hive.

I've opened a new issue with NPM as I genuinely think this is an NPM issue. It should not force install an optional peer dependency.

[enisdenjo]

I will be closing this issue as there is nothing I can do on graphql-ws side (aside from removing peer dependencies altogether).

[thekevinbrown]

Makes sense, thanks for having a look!