Update RichText in tutorial and use macro processors #690 #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a new factbox macro, updates existing content components to use the new RichText API, and bumps React component library versions.
- Registers and implements a
factboxmacro processor - Refactors
FactBox,Person, andArticlecomponents to consumeRichTextviacomponent,meta, andcommonprops - Updates dependencies
@enonic/react-componentsand@enonic-types/lib-react4xpto RC4
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/resources/react4xp/dataFetcher.ts | Imported factboxProcessor, added addMacro call |
| src/main/resources/react4xp/components/macro/FactboxProcessor.ts | New macro processor for factbox |
| src/main/resources/react4xp/components/macro/FactBox.tsx | Renamed config prop to data and updated usage in component |
| src/main/resources/react4xp/components/content/PersonProcessor.ts | Passed dataFetcher and component into processHtml |
| src/main/resources/react4xp/components/content/Person.tsx | Updated RichText calls to use meta, common, component |
| src/main/resources/react4xp/components/content/ArticleProcessor.ts | Added dataFetcher and component parameters to processHtml |
| src/main/resources/react4xp/components/content/Article.tsx | Switched RichText usage to new prop signature |
| package.json | Bumped @enonic/react-components and @enonic-types/lib-react4xp versions |
Comments suppressed due to low confidence (2)
src/main/resources/react4xp/components/macro/FactBox.tsx:6
- [nitpick] The filename 'FactBox.tsx' uses 'Box' with an uppercase B, but the component is named 'Factbox' (lowercase b). Consider renaming one to maintain consistent casing.
export const Factbox = ({data, children}: MacroComponentParams) => {
src/main/resources/react4xp/components/macro/FactboxProcessor.ts:1
- There are no unit tests for the new FactboxProcessor; consider adding tests to validate behavior when
macro.config['factbox']is present, missing, or malformed.
import type {ComponentProcessor, MacroProcessorParams} from '@enonic-types/lib-react4xp/DataFetcher';
| @@ -18,3 +19,5 @@ dataFetcher.addPart('com.enonic.app.hmdb:child-list', {processor: childListProce | |||
| dataFetcher.addContentType('com.enonic.app.hmdb:playlist', {processor: playlistProcessor}); | |||
| dataFetcher.addContentType('com.enonic.app.hmdb:article', {processor: articleProcessor}); | |||
|
|
|||
| // @ts-ignore update type in addMacro | |||
There was a problem hiding this comment.
Avoid using ts-ignore; consider updating the DataFetcher.addMacro type definitions to accept MacroProcessorParams so you can remove the ts-ignore directive.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.