Editing fractional value in Account balance messed up percentage calculations

[dinesh-58]

When checking the balance for my banking accounts, I saw that the 'Account Details' page showed fractional amounts accurately (e.g: 592.51) but in the 'Edit Account' page, they show up inaccurately (like 592.510000000001). I edited the amounts for 2 accounts thinking they would be more accurate. That seems to have messed up the calculations for the trend / percentage changed in the dashboard (see below):

I looked through the code a bit and seems balances are stored using double type after reading from the database? Found a StackOverflow answer with better ways to handle floats in Dart.

[dinesh-58]

I've found a few other issues too. Hope it doesn't feel like I'm complaining too much about the project or anything. I'll see if I can help with the open issues.

[enrique-lozano]

Don't worry! This app is still just getting started, and it's normal that a lot of new things come out. Feel free to create whatever you want; that will help me a lot.

Of course, users need to understand that I'm developing this alone and I have a full-time job and other projects, so resolving all these issues may take longer than expected. Therefore, I welcome any PR from any user who wants to collaborate 🙂

[enrique-lozano]

Wow, that seems like a really really important bug. Would you mind creating an issue with a video reproducing this behaviour?

[dinesh-58]

I was about to open an issue but I wasn't fully sure what was causing this so might be better to discuss here for now.

Firstly, I imported some old data from Ivy Wallet by converting it using this script. I don't think the converted file had any corrupted data. I'll attach the file and include some details about it below.

After importing, here's a video reproducing the behavior:
https://github.com/user-attachments/assets/87b6f15c-5d7d-4ce1-aa4d-871809bb8bf5

Some things to note here:

1. Balance trend / change percentage is at infinity after importing
2. The Account Details page for an account shows the account balance upto 2 decimal digits, but the edit page may show more than that (shown for eSewa and the bank account here, but doesn't show for Cash account)
   • Note how pressing backspace once deletes all decimal digits upto the 1st 2 digits. This might be caused by the balance input being limited to 2 decimal digits? I had some strange behavior when importing another sample csv where pressing backspace would clear the entire balance instead of just 1 digit.
3. After adjusting the account balance to 2 decimals, the balance change percentage is shown as a very large number

So, I think the issue here isn't really caused by editing the account balance, but by floating point inaccuracy of whatever data type is used to represent amounts (double?). None of the transactions in the csv have more than 2 decimal digits. This link I posted in the initial post description might help?

[dinesh-58]

Here's the csv file with sensitive data removed if you want to try and recreate this. I might have messed up something while editing the csv because importing it shows the message RangeError (length): Invalid value: Only valid value is 0: 5. Despite that, all the data seems to have been imported as the total balance is accurate (2387.44). Let me know if you want me to email you the original csv. The Date column has microseconds as well but seems you can just ignore it and use the default Date format when importing.