removed apiKey and secret flags from deploy commands

Author: liranfarage89

node/src/config/arguments.js

@@ -26,7 +26,7 @@ const argumentsMap = {
     description: 'env0 API Key',
     prompt: 'env0 API Key',
     secret: true,
-    group: ['deploy', 'destroy', 'approve', 'cancel', 'configure', 'agents-settings-list-agents']
+    group: ['configure']
   },
   [API_SECRET]: {
     name: API_SECRET,
@@ -35,7 +35,7 @@ const argumentsMap = {
     description: 'env0 API Secret',
     prompt: 'env0 API Secret',
     secret: true,
-    group: ['deploy', 'destroy', 'approve', 'cancel', 'configure', 'agents-settings-list-agents']
+    group: ['configure']
   },
   [ORGANIZATION_ID]: {
     name: ORGANIZATION_ID,
@@ -154,5 +154,10 @@ module.exports = {
     argumentsMap[ORGANIZATION_ID],
     argumentsMap[PROJECT_ID],
     argumentsMap[ENVIRONMENT_NAME]
+  ],
+  nonCredentialBaseArguments: [
+    argumentsMap[ORGANIZATION_ID],
+    argumentsMap[PROJECT_ID],
+    argumentsMap[ENVIRONMENT_NAME]
   ]
 };

node/src/config/commands.js

@@ -1,4 +1,4 @@
-const { argumentsMap, allArguments, baseArguments } = require('./arguments');
+const { argumentsMap, allArguments, baseArguments, nonCredentialBaseArguments } = require('./arguments');
 const { options } = require('./constants');
 const deploy = require('../commands/deploy');
 const destroy = require('../commands/destroy');
@@ -16,7 +16,7 @@ const commands = {
     handler: deploy,
     requiredOptions: BASE_REQUIRED_OPTIONS,
     useDeployUtils: true,
-    options: allArguments,
+    options: allArguments.filter(option => ![API_KEY, API_SECRET].includes(option.name)),
     help: [
       {
         desc: 'Deploys an environment',
@@ -28,7 +28,7 @@ const commands = {
     handler: destroy,
     requiredOptions: BASE_REQUIRED_OPTIONS,
     useDeployUtils: true,
-    options: [...baseArguments, argumentsMap[REQUIRES_APPROVAL], argumentsMap[SKIP_STATE_REFRESH]],
+    options: [...nonCredentialBaseArguments, argumentsMap[REQUIRES_APPROVAL], argumentsMap[SKIP_STATE_REFRESH]],
     help: [
       {
         desc: 'Destroys an environment',
@@ -40,7 +40,7 @@ const commands = {
     handler: approve,
     requiredOptions: BASE_REQUIRED_OPTIONS,
     useDeployUtils: true,
-    options: baseArguments,
+    options: nonCredentialBaseArguments,
     help: [
       {
         desc: 'Accepts a deployment that is pending approval',
@@ -64,7 +64,7 @@ const commands = {
     handler: agentsSettingsListAgents,
     requiredOptions: ORG_REQUIRED_OPTIONS,
     useDeployUtils: false,
-    options: baseArguments,
+    options: nonCredentialBaseArguments,
     help: [
       {
         desc: 'Lists organization agents',

node/tests/main.spec.js

@@ -2,6 +2,7 @@ const runCommand = require('../src/commands/run-command');
 const run = require('../src/main');
 const commandLineArgs = require('command-line-args');
 const { commands } = require('../src/config/commands');
+const { options } = require('../src/config/constants');
 const { version } = require('../package.json');
 const help = require('../src/commands/help');
 const configure = require('../src/commands/configure');
@@ -159,6 +160,26 @@ describe('main', () => {
       });
     });
 
+    describe('auth flags exposure', () => {
+      const { API_KEY, API_SECRET } = options;
+
+      const getOptionNames = command => (commands[command].options || []).map(opt => opt.name);
+
+      it('should not expose apiKey/apiSecret flags for runtime commands', () => {
+        ['deploy', 'destroy', 'cancel', 'approve', 'agents-settings-list-agents'].forEach(command => {
+          const names = getOptionNames(command);
+          expect(names).not.toContain(API_KEY);
+          expect(names).not.toContain(API_SECRET);
+        });
+      });
+
+      it('should still expose apiKey/apiSecret flags for configure', () => {
+        const names = getOptionNames('configure');
+        expect(names).toContain(API_KEY);
+        expect(names).toContain(API_SECRET);
+      });
+    });
+
     describe('variables parsing', () => {
       describe.each`
         command