feat!: support 'source' property in Interceptor #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
src/main/java/com/epam/aidial/cfg/dao/model/InterceptorEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/com/epam/aidial/cfg/domain/service/ExternalDeploymentScheduledService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/epam/aidial/cfg/domain/service/ExternalDeploymentScheduledService.java
Outdated
Show resolved
Hide resolved
...n/java/com/epam/aidial/cfg/domain/service/InterceptorEndpointsRefresherScheduledService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/epam/aidial/cfg/domain/service/InterceptorService.java
Outdated
Show resolved
Hide resolved
src/main/resources/db/migration/MS_SQL_SERVER/V1.45__AddContainerIdToInterceptorTable.sql
Outdated
Show resolved
Hide resolved
src/main/resources/db/migration/H2/V1.45__AddContainerIdToInterceptorTable.sql
Outdated
Show resolved
Hide resolved
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
src/main/java/com/epam/aidial/cfg/domain/model/source/InterceptorRunnerSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/epam/aidial/cfg/domain/service/ExternalDeploymentScheduledService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/epam/aidial/cfg/domain/service/ExternalDeploymentScheduledService.java
Outdated
Show resolved
Hide resolved
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
src/main/java/com/epam/aidial/cfg/domain/service/InterceptorService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/epam/aidial/cfg/domain/service/InterceptorService.java
Outdated
Show resolved
Hide resolved
...n/java/com/epam/aidial/cfg/domain/service/InterceptorEndpointsRefresherScheduledService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/epam/aidial/cfg/domain/validator/InterceptorValidator.java
Outdated
Show resolved
Hide resolved
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
src/main/java/com/epam/aidial/cfg/dao/mapper/InterceptorEntityMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/com/epam/aidial/cfg/domain/service/EndpointsRefreshEnabledCondition.java
Outdated
Show resolved
Hide resolved
src/main/java/com/epam/aidial/cfg/domain/service/InterceptorService.java
Show resolved
Hide resolved
src/main/java/com/epam/aidial/cfg/domain/service/InterceptorService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/epam/aidial/cfg/domain/service/InterceptorRefreshService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/epam/aidial/cfg/domain/util/InterceptorEndpointUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/epam/aidial/cfg/domain/util/InterceptorEndpointUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/epam/aidial/cfg/domain/service/ExternalDeploymentService.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private DeploymentInfoDto getDeploymentInfoDto(String id) { | ||
| if (StringUtils.isBlank(deploymentClientUrl)) { |
There was a problem hiding this comment.
Could you please clarify the purpose of the custom exception?
There was a problem hiding this comment.
Because none of existing fits. What's the problem?
There was a problem hiding this comment.
I mean why do we need to separate case when deploymentClientUrl is not set from any other cases?
There was a problem hiding this comment.
InterceptorImporter line 89
There was a problem hiding this comment.
Just to log warning message "Failed to get deployment" instead of logging error message?
When DeploymentClientNotExistsException is thrown, deploymentInfo in InterceptorImporter stays null, when any other exception is thrown error message is logged in this class but deploymentInfo in InterceptorImporter still stays null
There was a problem hiding this comment.
That's important to know that deployment was expected, but wasn't found. We have plans to have pop-up warning messages on FE that will inform about issues during endpoints refresh/unsuccessful import of interceptors linked to containers
src/main/java/com/epam/aidial/cfg/domain/service/InterceptorService.java
Show resolved
Hide resolved
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
src/main/java/com/epam/aidial/cfg/domain/util/InterceptorEndpointResolver.java
Show resolved
Hide resolved
# Conflicts: # src/test/java/com/epam/aidial/cfg/functional/tests/ConfigTransferFunctionalTest.java
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
siarhei-fedziukovich
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable issues
sourceproperty which allow to refer intercpetor template or container #65Description of changes
BREAKING CHANGE: 'interceptorRunner' property is removed from Interceptor. Instead, 'source' property is added.
Source can be of three types: endpoints, runner or container.
When source is container, endpoint base URL is retrieved from MCP manager. Interceptor endpoints are refreshed on schedule to handle the case when container URL changes.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.