Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Modularize recon-pipeline.py's ReconShell class #88

Open
epi052 opened this issue Aug 15, 2020 · 0 comments
Open

[IMPROVEMENT] Modularize recon-pipeline.py's ReconShell class #88

epi052 opened this issue Aug 15, 2020 · 0 comments
Labels
enhancement New feature or request low priority

Comments

@epi052
Copy link
Owner

epi052 commented Aug 15, 2020

Is your feature request related to a problem? Please describe.
The ReconShell class's monolithic design has grown to nearly 1000 lines of code. Making changes to it can be daunting and things that need to be changed can be hard to locate.

Describe the solution you'd like
The cmd2 team added a feature in 1.3.0 called CommandSets that allow for modularization of cmd2 applications. This seems like a perfect fit.

Describe alternatives you've considered
I've considered rolling my own modular structure using a MetaClass, as I've been successful with this strategy in the past, however with it being a builtin feature of cmd2, it feels too good to pass up.
@epi052 epi052 added enhancement New feature or request low priority labels Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epi052