feat: Adding Examples for Python SDK to create FCR and FCR based Connections#22
Merged
feat: Adding Examples for Python SDK to create FCR and FCR based Connections#22
Conversation
thogarty
requested changes
Aug 26, 2024
Contributor
thogarty
left a comment
thogarty
left a comment
There was a problem hiding this comment.
Some nitpicking to clean up. Rest looks good though. Thanks, @jkallem-equinix !
examples/services/fabricv4/oauth2/configure_client_credentials.py
Outdated
Show resolved
Hide resolved
examples/services/fabricv4/oauth2/configure_client_credentials.py
Outdated
Show resolved
Hide resolved
examples/services/fabricv4/connections/fcr_2_port_connection.py
Outdated
Show resolved
Hide resolved
| This method interacts with the Equinix Fabric API to fetch detailed information about a specific connection | ||
| identified by its UUID. The response is then formatted into a JSON string for easier readability and logged | ||
| for debugging purposes. | ||
| """ |
Contributor
There was a problem hiding this comment.
nit: closing triple quotes not at same level of indentation as openers
examples/services/fabricv4/connections/connection_management.py
Outdated
Show resolved
Hide resolved
| This method handles the process of establishing a connection between a Fabric Cloud Router (FCR) and a | ||
| colocation or another FCR within the Equinix Fabric. It generates the connection request payload, | ||
| sends the request to the Equinix Fabric API, and returns the unique identifier (UUID) of the created connection. | ||
| """ |
Contributor
There was a problem hiding this comment.
nit: closing triple quotes not at same level of indentation as openers
thogarty
approved these changes
Aug 28, 2024
Contributor
thogarty
left a comment
thogarty
left a comment
There was a problem hiding this comment.
LGTM. Thanks, @jkallem-equinix !
Contributor
|
This PR is included in version 0.4.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CXF-96059 Adding Examples for Python SDK:
Fabric Cloud Router
FCR to Port, AWS, Azure Connections:
Connections