Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update actions should have option to clear, remove, and add tags #391

Open
displague opened this issue Nov 16, 2023 · 0 comments
Open

update actions should have option to clear, remove, and add tags #391

displague opened this issue Nov 16, 2023 · 0 comments

Comments

@displague
Copy link
Member

displague commented Nov 16, 2023

It should also be possible to add, remove, and clear tags.
This should be implemented in a common way across all resources with tags.

Would I expect this command to add a tag or reset all tags:

  • metal thing update --tags foo // reset to one tag - foo?
  • metal thing update --tags // clear all?
  • metal thing update --tag foo // add a single tag foo? with no way to remove a single tag foo?
  • metal thing update --tag -foo --remove-tag foo? Since there is no API call to remove a tag, would we full fetch and remove tags as part of update?

I think there is more to consider on tag setting. Happy to consider that outside of the scope of this PR and simply document the behavior this command uses for now.

metal thing update --add-tag=foo
metal thing update --add-tag-if-not-present=foo // do we go this far to avoid foo,foo,foo tags, which are possible iirc
metal thing update --remove-tag=foo

Originally posted by @displague in #369 (comment)

@displague displague changed the title update command should have option to clear, remove, and add tags update actions should have option to clear, remove, and add tags Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant