Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: no column header when running metal capacity get without any [--options] #488

Open
waltribeiro opened this issue Aug 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@waltribeiro
Copy link
Contributor

waltribeiro commented Aug 30, 2024

What problem are you facing?

The first table header is empty when running metal capacity get without any [--options].

column-00

However, including an option will return all column headers, for examplemetal capacity get -m sv.

column-01

Thoughts

So the first column has no context that ml1 or ld7 refer to the data centers. And if we put a header there, then I suggest "DC" rather than "METRO" (because a 'DC' header works whether it's a metro or a facility).

Steps To Recreate

  1. Deploy a server on console.equinix.com
  2. Run command metal capacity get (the first column header will be empty)
  3. Run command metal capacity get -m sv (all column headers will be populated)

How could the Equinix Metal CLI help solve this problem?

Perhaps leaving it empty was intended because LocationField in Line 92 refers to both Metros and Facilities, so as to avoid a metros/facilities header conflict in that first column (?).

column-main

Notes

I confirmed that all other get commands have table headers, some examples from Docs:

metal device get
metal event get
metal gateway get
metal hardware-reservation get

So metal capacity get seems to be the only column header that returns empty.

Note

I submitted this as a feature instead of a bug because the empty header is not breaking anything.

CLI version (metal --version): metal version 0.24.0

@waltribeiro waltribeiro added the enhancement New feature or request label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant