Skip to content

Non-virtual destructor on SequenceVerificationProgress can give compile error on later versions of Visual Studio 2022 #357

@malcolmdavey

Description

@malcolmdavey

The class SequenceVerificationProgress has virtual methods, but the destructor is non-virtual

e.g. VS 2022 (17.14) with C++ language set to "lastest C++ working draft"

fakeit.hpp(9741,10): error C4265: 'fakeit::SequenceVerificationProgress': class has virtual functions, but its non-trivial destructor is not virtual; instances of this class may not be destructed correctly

Problem line

~SequenceVerificationProgress() FAKEIT_THROWS { };

Suggested fix

virtual ~SequenceVerificationProgress() FAKEIT_THROWS = default;

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions