[BUG] kitty scrollback_pager kak -ro colors

[razcore-rad]

Version of Kakoune

v2020.09.01-1320-g94192402

Reproducer

1. Install kitty
2. Install starship
3. Set kitty scrollback_pager to kak -ro

Outcome

In between lines there's this color code that isn't rendered correctly in the pager (CTRL+SHIFT+h)

Welcome to fish, the friendly interactive shell
Type help for instructions on how to use fish
]133;A�\
�~ 
❯ 
]133;A�\
�~ 
❯ 

Expectations

Additional information

No response

---

This is a mawww/kakoune#4801 copy-paste. I noticed I actually use this plugin and was diverted here. Thanks :)

[occivink]

I wonder if this is not due to the use of the -ro flag, which prevents kak-ansi from removing the escape sequences. Could you try without? If that works a possible solution would be to only set the read-only flag once all data has been received from stdin (and the escape sequences processed).

[razcore-rad]

Yea, I already tried without the -ro flag. That's not it.

[eraserhd]

I have the following keybindings:

          "shift+ctrl+g" = "launch --stdin-add-formatting --stdin-source=@screen_scrollback --cwd=current --type=overlay ${pkgs.local.kak-scrollback-pager}/bin/kak-scrollback-pager @scrolled-by @cursor-x @cursor-y @line-count";
          "shift+ctrl+h" = "launch --stdin-add-formatting --stdin-source=@last_cmd_output --cwd=current --type=overlay ${pkgs.local.kak-scrollback-pager}/bin/kak-scrollback-pager @scrolled-by @cursor-x @cursor-y @line-count";

And here's the script:

https://github.com/eraserhd/dotfiles/blob/6c8527a89c9c719cc38b6d515409a97e738ba629/pkg/kak-scrollback-pager/kak-scrollback-pager.bash

The script is to make sure the cursor is in the same place once scrollback mode is entered (which has a few weird quirks that need to be worked around).