Merge pull request #563 from erikdarlingdata/dev

Dev

Author: erikdarlingdata

CLAUDE.md

@@ -255,10 +255,11 @@ This document outlines the T-SQL coding style preferences for Erik Darling (Darl
 
 - **INSERT statements**:
   - INSERT on first line
+  - Always use INSERT INTO
   - Schema and table name on next line, indented
   - Column list in parentheses on new lines, indented
   ```sql
-  INSERT
+  INSERT INTO
       dbo.table_name
   (
       column1,

sp_IndexCleanup/sp_IndexCleanup.sql

@@ -775,14 +775,14 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
         filter_definition nvarchar(max) NULL,
         missing_included_columns nvarchar(max) NULL,
         should_include_filter_columns bit NOT NULL,
-        PRIMARY KEY CLUSTERED(database_id, schema_id, object_id, index_id)
+        INDEX c CLUSTERED(database_id, schema_id, object_id, index_id)
     );
 
     /* Parse @include_databases comma-separated list */
     IF  @get_all_databases = 1
     AND @include_databases IS NOT NULL
     BEGIN
-        INSERT
+        INSERT INTO
             #include_databases
         WITH
             (TABLOCK)
@@ -825,7 +825,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
     IF  @get_all_databases = 1
     AND @include_databases IS NOT NULL
     BEGIN
-        INSERT
+        INSERT INTO
             #requested_but_skipped_databases
         WITH
             (TABLOCK)
@@ -875,7 +875,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
     IF  @get_all_databases = 1
     AND @exclude_databases IS NOT NULL
     BEGIN
-        INSERT
+        INSERT INTO
             #exclude_databases
         WITH
             (TABLOCK)
@@ -980,7 +980,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
         /* Single database mode */
         IF @database_name IS NOT NULL
         BEGIN
-            INSERT
+            INSERT INTO
                 #databases
             WITH
                 (TABLOCK)
@@ -1008,7 +1008,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
     ELSE
     BEGIN
         /* Multi-database mode */
-        INSERT
+        INSERT INTO
             #databases
         WITH
             (TABLOCK)
@@ -1109,6 +1109,12 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
             #key_duplicate_dedupe;
         TRUNCATE TABLE
             #include_subset_dedupe;
+        TRUNCATE TABLE
+            #computed_columns_analysis;
+        TRUNCATE TABLE
+            #check_constraints_analysis;
+        TRUNCATE TABLE
+            #filtered_index_columns_analysis;
 
          /*Validate searched objects per-database*/
          IF  @schema_name IS NOT NULL
@@ -1309,7 +1315,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
         PRINT @sql;
     END;
 
-    INSERT
+    INSERT INTO
         #filtered_objects
     WITH
         (TABLOCK)
@@ -1523,23 +1529,6 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
         @sql = N'
     SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-    INSERT
-        #computed_columns_analysis
-    WITH
-        (TABLOCK)
-    (
-        database_id,
-        database_name,
-        schema_id,
-        schema_name,
-        object_id,
-        table_name,
-        column_id,
-        column_name,
-        definition,
-        contains_udf,
-        udf_names
-    )
     SELECT DISTINCT
         fo.database_id,
         fo.database_name,
@@ -1591,6 +1580,23 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
         PRINT @sql;
     END;
 
+    INSERT INTO
+        #computed_columns_analysis
+    WITH
+        (TABLOCK)
+    (
+        database_id,
+        database_name,
+        schema_id,
+        schema_name,
+        object_id,
+        table_name,
+        column_id,
+        column_name,
+        definition,
+        contains_udf,
+        udf_names
+    )
     EXECUTE sys.sp_executesql
         @sql;
 
@@ -1610,23 +1616,6 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
         @sql = N'
     SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-    INSERT
-        #check_constraints_analysis
-    WITH
-        (TABLOCK)
-    (
-        database_id,
-        database_name,
-        schema_id,
-        schema_name,
-        object_id,
-        table_name,
-        constraint_id,
-        constraint_name,
-        definition,
-        contains_udf,
-        udf_names
-    )
     SELECT DISTINCT
         fo.database_id,
         fo.database_name,
@@ -1675,6 +1664,23 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
         PRINT @sql;
     END;
 
+    INSERT INTO
+        #check_constraints_analysis
+    WITH
+        (TABLOCK)
+    (
+        database_id,
+        database_name,
+        schema_id,
+        schema_name,
+        object_id,
+        table_name,
+        constraint_id,
+        constraint_name,
+        definition,
+        contains_udf,
+        udf_names
+    )
     EXECUTE sys.sp_executesql
         @sql;
 
@@ -1773,7 +1779,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
         PRINT @sql;
     END;
 
-    INSERT
+    INSERT INTO
         #operational_stats
     WITH
         (TABLOCK)
@@ -2031,7 +2037,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
         PRINT SUBSTRING(@sql, 4000, 8000);
     END;
 
-    INSERT
+    INSERT INTO
         #index_details
     WITH
         (TABLOCK)
@@ -2247,7 +2253,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
         PRINT SUBSTRING(@sql, 4000, 8000);
     END;
 
-    INSERT
+    INSERT INTO
         #partition_stats WITH(TABLOCK)
     (
         database_id,
@@ -2531,7 +2537,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
     END;
 
     /* Analyze filtered indexes to identify columns used in filters that should be included */
-    INSERT
+    INSERT INTO
         #filtered_index_columns_analysis
     WITH
         (TABLOCK)
@@ -2548,7 +2554,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
         missing_included_columns,
         should_include_filter_columns
     )
-    SELECT
+    SELECT DISTINCT
         ia.database_id,
         ia.database_name,
         ia.schema_id,