Skip to content

Coherence in JT Algorithm Lecture Notes #188

Open
@manonromain

Description

@manonromain

Hi! In the Junction Tree Algorithm Lecture Notes, I noted some inconsistencies w.r.t. factor graphs. In - that order, I quote:

  • First: "Sum-product message passing can also be applied to factor trees with a slight modification. Recall that a factor graph is a bipartite graph with edges going between variables and factors, with an edge signifying a factor depends on a variable." but factor trees are not mentioned before in the lecture notes.
  • Later, note 5. : "Arbitrary potentials can be handled using an algorithm called LBP on factor graphs. We will include this material at some point in the future."

Reading the notes and understanding what factor trees/graphs is doable, but the phrasing/order is confusing. I'll try submitting a pull request later in the quarter.

Thank you!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @manonromain

        Issue actions

          Coherence in JT Algorithm Lecture Notes · Issue #188 · ermongroup/cs228-notes